#6324 closed defect (fixed)
Patch to fix 'occured' & 'occurance' typos
| Reported by: | Bas Couwenberg | Owned by: | warmerdam |
|---|---|---|---|
| Priority: | normal | Milestone: | 2.1.0 |
| Component: | default | Version: | 1.11.3 |
| Severity: | normal | Keywords: | |
| Cc: | Kurt Schwehr |
Description
The lintian QA tool reported these spelling errors for GDAL 1.11.4 RC1:
- occured -> occurred
- occurance -> occurrence
The attached patch fixes the issues, but I've refrained from fixing the typo in variable and method names to not break the ABI.
Attachments (3)
Change History (8)
by , 8 years ago
| Attachment: | occurred-typo.patch added |
|---|
comment:1 by , 8 years ago
| Cc: | added |
|---|
comment:2 by , 8 years ago
I can check trunk too, because I have similar patches for 2.0.2 RC1.
These should at least be fixed in trunk, were the methods and variables can be changed too.
by , 8 years ago
| Attachment: | occurred-occurrence-trunk.patch added |
|---|
occurred-typo.patch updated for trunk
by , 8 years ago
| Attachment: | occurred-methods-variables-trunk.patch added |
|---|
Fix occurred typo in methods & variables
comment:3 by , 8 years ago
| Milestone: | 1.11.4 → 2.1.0 |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
trunk r33102 "Fix typos for 'occurred'/'ocurrence' (patch by sebastic, #6324)"
Long term, it would be ideal to have those checks added in one of our continuous integration target rather than discovering the issues late in the process. I looked quickly at the lintian doc and it seems to operate only on a package. No way to make it work rather with a source tree for typo checks ?
comment:4 by , 8 years ago
lintian is mostly useful in the context of a Debian package build, although its data files can be used as a basis for other whitelists. QGIS took a similar approach with its chkspelling.sh and spelling.dat.
In general I recommend the codespell utility for use in upstream regression tests and such.
Maybe Kurt wants to check if this is well taken into account into trunk after his many similar fixes. But I don't think we'll patch older branches for just typos.