Opened 8 years ago
Last modified 8 years ago
#6299 closed defect
Logic error in GNMGenericNetwork::LoadGraph() — at Initial Version
| Reported by: | Even Rouault | Owned by: | bishop |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | default | Version: | unspecified |
| Severity: | normal | Keywords: | gnm |
| Cc: |
Description
Coverity Scan raises that the following tests in GNMGenericNetwork::LoadGraph() can only evaluate to FALSE since they are in a block controlled by if(bIsBlock) but "bool bIsBlock = GNM_BLOCK_NONE == nBlockState;"
if(nBlockState & GNM_BLOCK_SRC)
m_oGraph.ChangeBlockState(nSrcFID, bIsBlock);
if(nBlockState & GNM_BLOCK_TGT)
m_oGraph.ChangeBlockState(nTgtFID, bIsBlock);
if(nBlockState & GNM_BLOCK_CONN)
m_oGraph.ChangeBlockState(nConFID, bIsBlock);
The warning looks justified.
Note:
See TracTickets
for help on using tickets.
