Opened 9 years ago
Closed 5 years ago
#6165 closed task (wontfix)
Remove "using namespace std;" from C++ code
Reported by: | Kurt Schwehr | Owned by: | Kurt Schwehr |
---|---|---|---|
Priority: | normal | Milestone: | closed_because_of_github_migration |
Component: | default | Version: | svn-trunk |
Severity: | normal | Keywords: | |
Cc: |
Description
It would be more obvious to readers if these are switched to using-declarations. e.g.
using std::map;
Existing that I propose removing:
find gdal -name \*.cpp -o -name \*.h | xargs egrep 'using namespace std' gdal/frmts/kmlsuperoverlay/kmlsuperoverlaydataset.cpp:using namespace std; gdal/frmts/msg/msgcommand.cpp:using namespace std; gdal/frmts/msg/reflectancecalculator.cpp:using namespace std; gdal/ogr/ogrsf_frmts/geojson/ogrgeojsondatasource.cpp:using namespace std; gdal/ogr/ogrsf_frmts/ili/ili2reader.cpp:using namespace std; gdal/ogr/ogrsf_frmts/ili/ogrili2datasource.cpp:using namespace std; gdal/ogr/ogrsf_frmts/libkml/ogrlibkmlfeaturestyle.cpp:using namespace std; gdal/swig/php/gdal_wrap.cpp:using namespace std; gdal/swig/php/ogr_wrap.cpp:using namespace std; gdal/swig/php/osr_wrap.cpp:using namespace std; gdal/swig/python/extensions/gdal_wrap.cpp:using namespace std; gdal/swig/python/extensions/ogr_wrap.cpp:using namespace std; gdal/swig/python/extensions/osr_wrap.cpp:using namespace std;
There are already some:
find gdal -name \*.cpp | xargs egrep 'using std::' gdal/frmts/elas/elasdataset.cpp:using std::fill; gdal/frmts/ilwis/ilwiscoordinatesystem.cpp:using std::string; gdal/frmts/ilwis/ilwisdataset.cpp:using std::string; gdal/frmts/ingr/IntergraphBand.cpp:using std::fill; gdal/frmts/raw/dipxdataset.cpp:using std::fill; gdal/ogr/ogrsf_frmts/filegdb/FGdbDatasource.cpp:using std::vector; gdal/ogr/ogrsf_frmts/filegdb/FGdbDatasource.cpp:using std::wstring; gdal/ogr/ogrsf_frmts/filegdb/FGdbLayer.cpp:using std::string; gdal/ogr/ogrsf_frmts/filegdb/FGdbLayer.cpp:using std::wstring; gdal/ogr/ogrsf_frmts/filegdb/FGdbResultLayer.cpp:using std::string; gdal/ogr/ogrsf_frmts/filegdb/FGdbResultLayer.cpp:using std::wstring; gdal/ogr/ogrsf_frmts/filegdb/FGdbUtils.cpp:using std::string;
Change History (1)
comment:1 by , 5 years ago
Milestone: | → closed_because_of_github_migration |
---|---|
Resolution: | → wontfix |
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
This ticket has been automatically closed because Trac is no longer used for GDAL bug tracking, since the project has migrated to GitHub. If you believe this ticket is still valid, you may file it to https://github.com/OSGeo/gdal/issues if it is not already reported there.