#6140 closed task (fixed)
Propose removing dist_docs/* - is burnpath really needed?
Reported by: | Kurt Schwehr | Owned by: | Kurt Schwehr |
---|---|---|---|
Priority: | normal | Milestone: | 2.1.0 |
Component: | default | Version: | svn-trunk |
Severity: | normal | Keywords: | |
Cc: |
Description
Do we still have a usecase for pszUpdatableINST_DATA in gdaldrivermanager.cpp? It appears to me that any situation that burnpath could be used to modify an existing shared or static binary object could be easily replaces by recompiling with INST_DATA defined pointing to the new location. It does not appear that burnpath or INST_DATA_TARGET is in active use in the source tree.
If this functionality is critical someplace, we should document that in gdaldrivermanager.cpp.
burnpath came in with r3234.
find . -type f | grep -v svn | xargs egrep 'dist_docs|burnpath|install_unx.sh|SETUP_GDAL.BAT' | grep -v /dist_docs/ ./makegdal_gen.bat: for %%d in (data debian dist_docs docs html m4 pymod swig vb6) do ( ./mkbindist.sh:cp dist_docs/README_UNX_BIN.TXT $DIST_DIR ./mkbindist.sh:cp dist_docs/install_unx.sh $DIST_DIR ./mkbindist.sh:cc -o $DIST_DIR/bin/burnpath dist_docs/burnpath.c ./mkgdaldist.sh:rm -rf gdal/dist_docs ./PROVENANCE.TXT:=== gdal/dist_docs ===
Patching binaries seems to be playing with fire.
Change History (6)
comment:1 by , 9 years ago
comment:3 by , 9 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:4 by , 9 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:5 by , 9 years ago
Milestone: | → 2.1.0 |
---|
Note:
See TracTickets
for help on using tickets.
I would not be offended by the removal of pszUpdableINST_DATA. I am not aware of anything that uses it currently.
I think I did use it for FWTools on linux, so update the paths at installation time without recompiling. But I don't imagine any normal packaging systems require this.