Opened 21 months ago

Closed 21 months ago

Last modified 4 months ago

#6140 closed task (fixed)

Propose removing dist_docs/* - is burnpath really needed?

Reported by: Kurt Schwehr Owned by: Kurt Schwehr
Priority: normal Milestone: 2.1.0
Component: default Version: svn-trunk
Severity: normal Keywords:
Cc:

Description

Do we still have a usecase for pszUpdatableINST_DATA in gdaldrivermanager.cpp? It appears to me that any situation that burnpath could be used to modify an existing shared or static binary object could be easily replaces by recompiling with INST_DATA defined pointing to the new location. It does not appear that burnpath or INST_DATA_TARGET is in active use in the source tree.

If this functionality is critical someplace, we should document that in gdaldrivermanager.cpp.

burnpath came in with r3234.

find . -type f | grep -v svn | xargs egrep 'dist_docs|burnpath|install_unx.sh|SETUP_GDAL.BAT' | grep -v /dist_docs/
./makegdal_gen.bat:    for %%d in (data debian dist_docs docs html m4 pymod swig vb6) do (
./mkbindist.sh:cp dist_docs/README_UNX_BIN.TXT $DIST_DIR
./mkbindist.sh:cp dist_docs/install_unx.sh $DIST_DIR
./mkbindist.sh:cc -o $DIST_DIR/bin/burnpath dist_docs/burnpath.c
./mkgdaldist.sh:rm -rf gdal/dist_docs
./PROVENANCE.TXT:=== gdal/dist_docs ===

Patching binaries seems to be playing with fire.

Change History (6)

comment:1 Changed 21 months ago by warmerdam

I would not be offended by the removal of pszUpdableINST_DATA. I am not aware of anything that uses it currently.

I think I did use it for FWTools on linux, so update the paths at installation time without recompiling. But I don't imagine any normal packaging systems require this.

comment:2 Changed 21 months ago by Kurt Schwehr

r30899 in trunk

comment:3 Changed 21 months ago by Kurt Schwehr

Owner: changed from warmerdam to Kurt Schwehr
Status: newassigned

comment:4 Changed 21 months ago by Kurt Schwehr

Resolution: fixed
Status: assignedclosed

comment:5 Changed 21 months ago by Even Rouault

Milestone: 2.1.0

comment:6 Changed 4 months ago by Mateusz Łoskot

r37381 - Remove dist_docs folder (dangling empty after r30899)

Note: See TracTickets for help on using tickets.