Opened 10 years ago
Closed 9 years ago
#5698 closed defect (fixed)
Can we remove the reference to horiz_cs.csv from cpl_csv.cpp?
Reported by: | Kurt Schwehr | Owned by: | Kurt Schwehr |
---|---|---|---|
Priority: | normal | Milestone: | 1.11.2 |
Component: | default | Version: | |
Severity: | normal | Keywords: | |
Cc: |
Description
source:trunk/gdal/port/cpl_csv.cpp#L1094 in GDALDefaultCSVFilename tests for opening horiz_cs.csv that hasn't existed in gdal for a long time. I found it in 1.1.7. Any complaints if I remove this block from trunk and 1.11-svn?
if( (fp = fopen( "csv/horiz_cs.csv", "rt" )) != NULL ) { strcpy( pTLSData->szPath, "csv/" ); CPLStrlcat( pTLSData->szPath, pszBasename, sizeof(pTLSData->szPath) ); }
https://svn.osgeo.org/gdal/tags/gdal_1_1_7/data/horiz_cs.csv
Change History (4)
comment:1 by , 10 years ago
comment:3 by , 9 years ago
r27958 on 1.11-svn branch post 1.11.1. This should be good to close if there are no failure reports
comment:4 by , 9 years ago
Milestone: | → 1.11.2 |
---|---|
Resolution: | → fixed |
Status: | assigned → closed |
Version: | svn-trunk |
I'm just closing now. It has been 4 weeks in trunk and nobody has complained.
Note:
See TracTickets
for help on using tickets.
Yes, I think you can go ahead with removing this. I presume that at this time csv/horiz_cs.csv was the equivalent of the now data/pcs.csv or data/gcs.csv. And that was shared by the libgeotiff of that time. So this was a trick to find the csv/data directory if GDAL run from the root of the GDAL tree. But we have now the GDAL_DATA env. variable or the logic in CPLFinderInit()