OGROCITableLayer::SetFeature DESTROY previous record

[giorgiomugnaini]

Current implementation of OGROCITableLayer::SetFeature destroy existing records instead of performing an update. Such behavior is not acceptable in presence of triggers or foreign keys.

[giorgiomugnaini]

	/* -------------------------------------------------------------------- */
	/*      Prepare the delete command, and execute.  We don't check the    */
	/*      error result of the execute, since attempting to Set a          */
	/*      non-existing feature may be OK.                                 */
	/* -------------------------------------------------------------------- */
	    OGROCIStringBuf     oCmdText;
	    OGROCIStatement     oCmdStatement( poDS->GetSession() );
	
	    oCmdText.Appendf( strlen(poFeatureDefn->GetName())+strlen(pszFIDName)+100,
	                      "DELETE FROM %s WHERE \"%s\" = %d",
	                      poFeatureDefn->GetName(), 
	                      pszFIDName, 
	                      poFeature->GetFID() );
	
	    oCmdStatement.Execute( oCmdText.GetString() );
	
	    return CreateFeature( poFeature );

[Even Rouault]

I agree this is non optimal behaviour. If needed, I could be contracted to improve this ( contact at spatialys.com )

[Even Rouault]

This ticket has been automatically closed because Trac is no longer used for GDAL bug tracking, since the project has migrated to GitHub. If you believe this ticket is still valid, you may file it to ​https://github.com/OSGeo/gdal/issues if it is not already reported there.