Opened 10 years ago
Closed 10 years ago
#5568 closed defect (fixed)
CPLHTTPSetOptions never sets CURLOPT_NOSIGNAL
Reported by: | Kyle Shannon | Owned by: | warmerdam |
---|---|---|---|
Priority: | normal | Milestone: | 1.11.1 |
Component: | default | Version: | unspecified |
Severity: | normal | Keywords: | curl |
Cc: |
Description
There is a call to set CURLOPT_NOSIGNAL in cpl_http.cpp that checks if CURLOPT_NOSIGNAL is defined. CURLOPT_NOSIGNAL is a member of an enumeration, and is never defined (see curl/curl.h). The comment mentions that version 7.10 and later support it, verified here:
http://curl.haxx.se/changes.html
The patch simply replaces the #define check with a curl version check.
Attachments (1)
Change History (4)
by , 10 years ago
Attachment: | curl.patch added |
---|
comment:1 by , 10 years ago
comment:2 by , 10 years ago
Even, I was messing around with CPLHTTPFetch with several threads and it appears dns lookup would timeout and send a signal, killing my process. It wasn't all the time, but it occasionally would happen. I'll apply.
comment:3 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Looks good. Did you get into situation where this was needed ? It looks like this error exists since the beginning