GPKG: Layers with dashes in the name cause sqlite errors

[ryanl]

Layers with a dash '-' causes the gpkg driver to exit with:

$ ogr2ogr -f gpkg hyphen.gpkg some-layer.shp
ERROR 1: sqlite3_exec(CREATE TABLE some-layer ( fid INTEGER PRIMARY KEY AUTOINCREMENT, geom LINESTRING )) failed: near "-": syntax error
ERROR 1: Terminating translation prematurely after failed

I was unable to find anything preventing dashes in the geopackage spec, so this could be fixed by quoting the name at ogrgeopackagedatasource.cpp:797, alternatively the check at ogrgeopackagedatasource.cpp:753 could be improved as strspn will only check for illegal prefixes.

[Even Rouault]

trunk r27343 "GPKG: allow table names with dash character (#5472)"

[Even Rouault]

Milestone renamed