Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#5330 closed enhancement (fixed)

ISO WKB generation with wkbVariant option

Reported by: pramsey Owned by: evenr
Priority: normal Milestone:
Component: OGR_SF Version: unspecified
Severity: normal Keywords: wkb
Cc: Kyle Shannon

Description

As discussed on mailing list, this patch adds a wkbVariant option to exportToWkb, allowing users to optionally use the ISO WKB numbers for Z-types.

Attachments (1)

isowkb.patch (23.9 KB) - added by pramsey 3 years ago.
patch passes all tests

Download all attachments as: .zip

Change History (7)

Changed 3 years ago by pramsey

Attachment: isowkb.patch added

patch passes all tests

comment:1 Changed 3 years ago by pramsey

Oh, patch is against SVN trunk at r26734

comment:2 Changed 3 years ago by Even Rouault

looks good to me. you can commit it

comment:3 Changed 3 years ago by pramsey

Resolution: fixed
Status: newclosed

Committed to trunk at r26736

comment:4 Changed 3 years ago by Kyle Shannon

Cc: Kyle Shannon added

Paul, I didn't see anything committed in autotest/. Probably a good idea to add regression tests for the new feature.

comment:5 Changed 3 years ago by Even Rouault

Kyle, for now, it's internal new functionnality that has no C bindings, so it cannot be tested through Python (except maybe the importFromWkb() that uses the same function/method). This work will be triggered by the GeoPackage driver that Paul is working on.

comment:6 Changed 3 years ago by Kyle Shannon

Ah, understood. It will get tested in the new driver tests. Thanks.

Note: See TracTickets for help on using tickets.