Opened 5 years ago

Closed 7 months ago

#5286 closed defect (fixed)

Some settings in nmake.local are overwriten in nmake.opt

Reported by: pmeems Owned by: warmerdam
Priority: normal Milestone:
Component: default Version: 1.10.1
Severity: normal Keywords:
Cc:

Description

I've created a nmake.local file so we don't need to change the GDAL files every time. This seems to be working fine except for the DLLBUILD settings. This setting is set in nmake.opt to 1, but we want to set it to 0. Because nmake.local is called at the beginning my setting is overwritten.

Solution is to check if the setting is already set, like it is done with other settings: Change line 171 DLLBUILD=1 to !IFNDEF DLLBUILD DLLBUILD=1 !ENDIF

Other settings might benefit from similar changes, like STDCALL, PAM_SETTING and INCLUDE_OGR_FRMTS

Change History (2)

comment:1 Changed 4 years ago by Jukka Rahkonen

This sounds reasonable for me but you must raise the attention of some developer with commit rights. I suggest to make a patch, attach it to this ticket, and edit the summary to begin with [PATCH]...

comment:2 Changed 7 months ago by Even Rouault

Resolution: fixed
Status: newclosed

In 41758:

nmake.opt: avoid some settings to be defined unconditionnaly (fixes #5286)

Note: See TracTickets for help on using tickets.