Opened 11 years ago

Closed 11 years ago

#5227 closed enhancement (fixed)

The IHO S-57 standard allows 65536 object classes

Reported by: hogend Owned by: warmerdam
Priority: normal Milestone: 1.10.2
Component: OGR_SF Version: 1.10.0
Severity: normal Keywords: s57
Cc: Kurt Schwehr

Description

In ogr/ogrsf_frmts/s57/s57.h:

#define MAX_CLASSES 23000

It is proposed to raise this to 65536, since new object classes > 23000 are sometimes being used to add special purpose objects. Patch attached

Attachments (1)

gdal_s57_classes.patch​ (1.1 KB ) - added by hogend 11 years ago.
patch against 1.10

Download all attachments as: .zip

Change History (5)

by hogend, 11 years ago

Attachment: gdal_s57_classes.patch​ added

patch against 1.10

comment:1 by hogend, 11 years ago

Component: default → OGR_SF

comment:2 by warmerdam, 11 years ago

Cc: Kurt Schwehr added
Keywords: s57 added
Status: new → assigned

comment:3 by warmerdam, 11 years ago

I have reworked the S57 code to avoid use of MAX_CLASSES altogether in favor of dynamic sizing in trunk (r26386).

comment:4 by warmerdam, 11 years ago

Milestone: → 1.10.2
Resolution: → fixed
Status: assigned → closed

I have a applied the suggested change of MAX_CLASSES in the 1.10 branch (r26389). It should appear in 1.10.2.

Note: See TracTickets for help on using tickets.