MSSQL driver should utilize MSSQL catalog if geometry_colums doesn't exist

[tamas]

Also:

• Use lazy initialization of layer definition to eliminate the need of querying for each table
• Look up spatial reference by srid if spatial_ref_sys metadata table doesn’t exist

[tamas]

Fixed in r25558

[Even Rouault]

I find the following line particularly suspicious :

bUseGeometryColumns = !CSLTestBoolean(CPLGetConfigOption("MSSQLSPATIAL_USE_GEOMETRY_COLUMNS", "NO"));

I guess it only works when MSSQLSPATIAL_USE_GEOMETRY_COLUMNS isn't set. But if someone sets MSSQLSPATIAL_USE_GEOMETRY_COLUMNS to NO, bUseGeometryColumns will be TRUE.

So I'd suggest removing the double negation : bUseGeometryColumns = CSLTestBoolean(CPLGetConfigOption("MSSQLSPATIAL_USE_GEOMETRY_COLUMNS", "YES"));

[tamas]

Replying to rouault:

I find the following line particularly suspicious :

bUseGeometryColumns = !CSLTestBoolean(CPLGetConfigOption("MSSQLSPATIAL_USE_GEOMETRY_COLUMNS", "NO"));

I guess it only works when MSSQLSPATIAL_USE_GEOMETRY_COLUMNS isn't set. But if someone sets MSSQLSPATIAL_USE_GEOMETRY_COLUMNS to NO, bUseGeometryColumns will be TRUE.

So I'd suggest removing the double negation : bUseGeometryColumns = CSLTestBoolean(CPLGetConfigOption("MSSQLSPATIAL_USE_GEOMETRY_COLUMNS", "YES"));

You might be true. Changed this way