Opened 6 years ago

Closed 3 years ago

#4676 closed task (fixed)

Update json-c library to version 0.11

Reported by: Mateusz Łoskot Owned by: Mateusz Łoskot
Priority: normal Milestone:
Component: default Version: svn-trunk
Severity: normal Keywords: json, geojson, json-c
Cc:

Description

Release branch for 0.10 version of json-c library has been created in https://github.com/json-c/json-c

AFAIK, it will be released soon.

I have been porting local GDAL modifications applied to json-c to the upstream. I maintain GDAL-specific changes to json-c in dedicated gdal-modifications branch on GitHub?. Some of these modifications have been accepted to upstream.

The port has been completed and I have tested it using Visual Studio 2010.

I'd like to submit update to json-c based on the pre-0.10 version to GDAL trunk, so people can start testing it. Next, I will pull this update on to Linux box continue testing there.

Any objections to submitting the new json-c to the trunk?

Change History (10)

comment:1 Changed 6 years ago by Mateusz Łoskot

Owner: changed from warmerdam to Mateusz Łoskot
Status: newassigned

comment:2 Changed 6 years ago by Even Rouault

Seems good to me (I assume the existing tests in ogr_geojson.py still pass on your Windows box)

comment:3 Changed 4 years ago by Even Rouault

Summary: Update json-c library to version 0.10Update json-c library to version 0.11

r26292 "Upgrade internal libjson-c to json-c 0.11 (#4676)"

comment:4 Changed 4 years ago by Even Rouault

For Windows build, this patch is necessary (has been applied in internal copy): https://github.com/json-c/json-c/pull/95

comment:5 Changed 4 years ago by Even Rouault

r26293 "Unix configure: add --with-libjson-c configure option to build against external libjson-c (>= 0.11) (#4676)"

comment:6 Changed 4 years ago by Even Rouault

r26285 "Remove include to json_object_private.h which is unnecessary since json_object_object_foreachC is now in json_object.h"

comment:7 Changed 4 years ago by Even Rouault

r26286 "Prefix symbols of internal libjson-c with gdal_ to avoid issues if an app links with GDAL and an external (older) libjsonc"

r26287 "Rename internal libjson directory from json-c to libjson to avoid include issues when linking against external libjson-c"

comment:8 Changed 4 years ago by Even Rouault

Arg typo: the last 3 commits are r26294, r26295 and r26296

comment:9 Changed 3 years ago by Jukka Rahkonen

Is there still something that should be done with update to json-c 0.11?

comment:10 Changed 3 years ago by Even Rouault

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.