Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#4443 closed defect (fixed)

Opening Tiger with full file name broken since r22622

Reported by: gaige Owned by: warmerdam
Priority: normal Milestone: 1.9.1
Component: OGR_SF Version: 1.9.0
Severity: normal Keywords:
Cc:

Description

A change was made in r22622 to fix a problem with file names running off the end of the strncpy. However, it also changed the behavior in terminating the string (the previous line was designed to remove the last character of the extension, making room for appending the final character.

I would suggest patching:

szModule[sizeof(szModule)-1] = '\0';

to add back in:

szModule[strlen(szModule)-1] = '\0';

(getting the solution to both problems.

And then add a test for using the full name (including complete extension) in gdalautotest/ogr_tiger.py

Cheers, -Gaige

Change History (2)

comment:1 Changed 7 years ago by Even Rouault

Milestone: 1.9.1
Resolution: fixed
Status: newclosed

Actually both lines are necessary. And a small comment would have avoided that confusion...

Fixed in trunk (r23770) and branches/1.9 (r23771)

comment:2 Changed 7 years ago by gaige

I'm sorry, I thought my "to add back in" and "getting the solution to both problems" were clear that both were necessary.

I'll attempt to be more concise and direct in the future.

-Gaige

Note: See TracTickets for help on using tickets.