Opened 12 years ago
Closed 12 years ago
#4401 closed enhancement (fixed)
[Patch]Extend test_ogrsf with a test case for delete&create feature
| Reported by: | rxna | Owned by: | Even Rouault |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.9.0 |
| Component: | OGR_SF | Version: | svn-trunk |
| Severity: | normal | Keywords: | test_ogrsf |
| Cc: |
Description
the new test case tries to delete the last feature from the test layer, then create it back.
Attachments (1)
Change History (4)
by , 12 years ago
| Attachment: | test_ogrsf.patch added |
|---|
comment:1 by , 12 years ago
| Summary: | Extend test_ogrsf with a test case for delete&create feature → [Patch]Extend test_ogrsf with a test case for delete&create feature |
|---|
comment:2 by , 12 years ago
| Owner: | changed from to |
|---|
comment:3 by , 12 years ago
| Milestone: | → 1.9.0 |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
r23602 /trunk/ (3 files in 3 dirs): test_ogrsf: add a test case for delete&create feature; declare OLCDeleteFeature for PG driver; adapt ogr_pcidsk.py to be 'expected_fail' on the new test (#4401, based on patch by rxna)
I've make a few changes in your patch itself to use SetNextByIndex() instead of iterating over the whole layer, which might be faster in some cases. And I've changed a bit a few changes, in particular because some drivers like Shapefile don't recreate features they have deleted with the same FID (emitting an INFO in that case).
Note:
See TracTickets
for help on using tickets.
Working on integrating it. It is not immediately trivial as not all drivers behave exactly the same.