Opened 8 years ago

Closed 8 years ago

#4128 closed defect (fixed)

TiledWMS minidriver: GetTileService xml parsing bug and solution

Reported by: serpinf Owned by: warmerdam
Priority: normal Milestone:
Component: GDAL_Raster Version: unspecified
Severity: normal Keywords:
Cc:

Description

TiledWMS minidriver fails to find TiledGroups? like "BMNG April" in GetTileService? xml with the following error: "GDALWMS, Tiled WMS: TiledGroupName? missing." The actual reason is bad logic in SearchLeafGroupName? function's 'metagroup' diagnostics: it erroneously assumes that TiledGroup? node is a metagroup child. The fix is a replacement of call to: SearchXMLSiblings(psRoot->psChild,"TiledGroup?") with CPLSearchXMLNode(psRoot->psChild,"=TiledGroup?") (minidriver_tiled_wms.cpp, line 101) P.S. sorry for not sending in an appropriate patch, but it seems so simple

Change History (3)

comment:1 Changed 8 years ago by Even Rouault

Can you point to a public service that exposes the issue ? Thanks

comment:2 in reply to:  1 Changed 8 years ago by serpinf

Replying to rouault:

Can you point to a public service that exposes the issue ? Thanks

Thanks for reply, an example that failed, but works for mt with the fix is: <GDAL_WMS>

<Service name="TiledWMS">

<ServerUrl?>http://onearth.jpl.nasa.gov/wms.cgi?</ServerUrl?> <TiledGroupName?>BMNG April</TiledGroupName?>

</Service>

</GDAL_WMS> The same is for other onearth BMNG data sources

comment:3 Changed 8 years ago by Even Rouault

Resolution: fixed
Status: newclosed

r22554 /trunk/gdal/frmts/wms/ (minidriver_tiled_wms.cpp wmsmetadataset.cpp wmsmetadataset.h): TiledWMS: recognize <TileGroup?> inside <TileGroups?> (#4128)

Note: See TracTickets for help on using tickets.