Opened 14 years ago
Closed 14 years ago
#3693 closed defect (fixed)
Overviews broken with PAM disabled
| Reported by: | gwalter | Owned by: | warmerdam |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.7.3 |
| Component: | default | Version: | 1.7.0 |
| Severity: | normal | Keywords: | overviews |
| Cc: |
Description
I built gdal 1.7.2 with PAM support disabled by default, and found that I could no longer build overviews for many formats. When I set the environment variable GDAL_PAM_ENABLED=YES, the overviews would build. I traced the problem down to the following section of GDALPamDataset::IBuildOverviews in gdalpamdataset.cpp:
PamInitialize(); if( psPam == NULL )
return CE_None;
When I replaced this with:
PamInitialize(); if( psPam == NULL )
return GDALDataset::IBuildOverviews( pszResampling,
nOverviews, panOverviewList, nListBands, panBandList, pfnProgress, pProgressData );
The overviews built again. However, I don't know much about PAM and haven't ever worked with it enabled (aside from the current troubleshooting effort), so I don't know if this change would mess things up in some cases when PAM is enabled.
Change History (1)
comment:1 by , 14 years ago
| Milestone: | → 1.7.3 |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
| Version: | 1.7.2 → 1.7.0 |
I've applied the proposed change. This was indeed a 1.7.0 regression.
r20146 /trunk/gdal/gcore/gdalpamdataset.cpp: Restore capability on creating overviews when PAM is disabled (#3693)
r20147 /trunk/autotest/gcore/pam.py: Verify we can create overviews on PNG with PAM disabled (#3693)
r20148 /branches/1.7/gdal/gcore/gdalpamdataset.cpp: Restore capability of creating overviews when PAM is disabled (#3693)