Opened 14 years ago
Closed 5 years ago
#3565 closed enhancement (wontfix)
revised RADARSAT2 driver
Reported by: | shawngong | Owned by: | pvachon |
---|---|---|---|
Priority: | normal | Milestone: | closed_because_of_github_migration |
Component: | default | Version: | unspecified |
Severity: | normal | Keywords: | |
Cc: | antonio |
Description
Adam Klein (my colleague) has revised RADARSAT2 driver so that it will ingest NITF SLC (Complex) products.
Sorry I cannot provide datasets for testing.
Attachments (2)
Change History (12)
by , 14 years ago
Attachment: | rs2dataset.cpp added |
---|
comment:1 by , 14 years ago
Type: | defect → enhancement |
---|
comment:2 by , 14 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:3 by , 14 years ago
Hi Shawn,
Can you please make sure that the changes you provide are based on the most recent revision of the GDAL trunk? There are quite a few disparities between trunk and the cpp file you provided, due to upstream changes in trunk. I'm happy to apply the changes if you do so (or at least give me a diff against the upstream version you're working against so I can more cleanly apply the changes).
Thanks, Phil
comment:4 by , 14 years ago
Hi Phil,
When you say "the most recent revision of the GDAL trunk", do you mean the overnight stable version? I'd appreciate a web link so I can be sure grabbing the right version.
thanks, Shawn
comment:5 by , 14 years ago
Hi Shawn,
The best way to do this is to grab the sources for GDAL via subversion:
svn checkout https://svn.osgeo.org/gdal/trunk/gdal (to just get the sources, without autotest and such)
Then apply the changes to the version of the sources in subversion, and you can do one of two things: a) send me the patched file, as you've done above b) send me a diff, generated with svn diff -u.
Cheers, Phil
comment:6 by , 14 years ago
Thanks Phil. I got the file. Will send you the fix tomorrow night.
Shawn
by , 14 years ago
Attachment: | rs2 driver.doc added |
---|
comment:7 by , 14 years ago
Phil, I compared with the RS2 driver from svn trunk. There are changes in only two places: 1) inserted between line 249 and 258 2) inserted lines 801, 801
Also please note that in order to display the RADARSAT2 NITF Complex properly, its ‘product.xml’ needs to be edited by changing ‘bitsPerSample’ for Real and Imaginary from 16 to 32. Otherwise you’ll see lots pixels with 0+0j. We have communicated with MDA about this.
comment:8 by , 13 years ago
Cc: | added |
---|
comment:10 by , 5 years ago
Milestone: | → closed_because_of_github_migration |
---|---|
Resolution: | → wontfix |
Status: | assigned → closed |
This ticket has been automatically closed because Trac is no longer used for GDAL bug tracking, since the project has migrated to GitHub. If you believe this ticket is still valid, you may file it to https://github.com/OSGeo/gdal/issues if it is not already reported there.
I'll have a look at this one.
P.