Opened 14 years ago

Closed 5 years ago

#3564 closed enhancement (wontfix)

revised TerraSAR driver

Reported by: shawngong Owned by: pvachon
Priority: normal Milestone: closed_because_of_github_migration
Component: default Version: unspecified
Severity: normal Keywords:
Cc: antonio

Description

TerraSAR GDAL driver can only utilizes 5 GCPs (4 coners plus centre). Adam Klein (my colleague) modified it so that it uses all GCPs in *.xml

I attached two output of gdalinfo, the 1st one is from the current GDAL driver; the 2nd one is from the revised drivr.

Attachments (4)

tsxdataset.cpp (26.6 KB ) - added by shawngong 14 years ago.
t1.txt (1.6 KB ) - added by shawngong 14 years ago.
t2.txt (184.4 KB ) - added by shawngong 14 years ago.
tsxdataset.cpp1 (26.8 KB ) - added by shawngong 14 years ago.

Download all attachments as: .zip

Change History (13)

by shawngong, 14 years ago

Attachment: tsxdataset.cpp added

by shawngong, 14 years ago

Attachment: t1.txt added

by shawngong, 14 years ago

Attachment: t2.txt added

comment:1 by shawngong, 14 years ago

Type: defectenhancement

comment:2 by pvachon, 14 years ago

Owner: changed from warmerdam to pvachon
Status: newassigned

comment:3 by pvachon, 14 years ago

I'll have a look through this code and make any comments. P.

comment:4 by pvachon, 14 years ago

Resolution: fixed
Status: assignedclosed

Hi Shawn,

I've applied the changes. Thanks for the code.

P.

comment:5 by shawngong, 14 years ago

Thanks, Phil

by shawngong, 14 years ago

Attachment: tsxdataset.cpp1 added

comment:6 by shawngong, 14 years ago

Resolution: fixed
Status: closedreopened

I submit an updated TerraSAR-X driver: tsxdataset.cpp1

Changes made by my coworker Adam Klein as follows:

  • Open() will return NULL when one of the raster bands cannot be loaded. This fix prevents a crash (dereferencing NULL pointer).
  • The driver no longer saves the image file pointer (it was never being used anyway) and does not clear the file pointer passed to Open() through GDALOpenInfo. This fix allows GDAL to close the image file when it is done with it.
  • Replace strdup() with CPLStrdup() for consistency
  • Calling CPLDestroyXMLNode() to clean up before returning NULL in Open()

comment:7 by antonio, 13 years ago

Cc: antonio added

comment:8 by Jukka Rahkonen, 9 years ago

Is there anybody out there to check the patch tsxdataset.cpp1?

comment:9 by Even Rouault, 5 years ago

Milestone: closed_because_of_github_migration
Resolution: wontfix
Status: reopenedclosed

This ticket has been automatically closed because Trac is no longer used for GDAL bug tracking, since the project has migrated to GitHub. If you believe this ticket is still valid, you may file it to https://github.com/OSGeo/gdal/issues if it is not already reported there.

Note: See TracTickets for help on using tickets.