cpcidskapmodel.cpp build failure

[warmerdam]

Tom Kralidis is seeing this build problem:

all  sdk/segment/cpcidskapmodel.cpp -o ../o/cpcidskapmodel.o
sdk/segment/cpcidskapmodel.cpp: In function 'void<unnamed>::BinaryToAPInfo(PCIDSK::PCIDSKBuffer&, PCIDSK::PCIDSKAPModelEOParams*&, PCIDSK::PCIDSKAPModelIOParams*&, PCIDSK::PCIDSKAPModelMiscParams*&, unsigned int&, unsigned int&, unsigned int&, std::string&, std::vector<double, std::allocator<double> >&, std::string&)':
sdk/segment/cpcidskapmodel.cpp:326: error: 'strncmp' was not declared in this scope
sdk/segment/cpcidskapmodel.cpp:337: error: 'strncmp' was not declared in this scope
sdk/segment/cpcidskapmodel.cpp:465: error: 'strncmp' was not declared in this scope
make[2]: *** [../o/cpcidskapmodel.o] Error 1
make[2]: Leaving directory `/home/tkralidi/foss4g/gdal/trunk/gdal/frmts/pcidsk'
make[1]: *** [pcidsk-install-obj] Error 2
make[1]: Leaving directory `/home/tkralidi/foss4g/gdal/trunk/gdal/frmts'
make: *** [frmts-target] Error 2

This persists after adding "#include <string>" in this file. I presume it relates to the use of an anonymous namespace around the offending region of code and Tom is using quite a new gcc.

For the time being I have #ifdef'ed out this code within the GDAL tree but it should be fixed in the sdk sandbox before the next updated of the gdal tree.

[pvachon]

Fixed in r19161. Forgot that gcc-4.4 is more pedantic about what is being included (a good thing!).

P.