Opened 14 years ago

Closed 14 years ago

#3391 closed defect (fixed)

MapInfo driver doesn't create a layer defn at layer creation.

Reported by: Even Rouault Owned by: chaitanya
Priority: normal Milestone:
Component: OGR_SF Version: unspecified
Severity: normal Keywords: mitab
Cc: Daniel Morissette, warmerdam, aboudreault

Description

This is related to #3384. When creating a new layer to a MapInfo datasource, the layer defn is NULL before any field definition has been added with CreateField(). This is a rather unusual behaviour for a OGR driver and caused ogr2ogr to crash. It would be desirable, if possible, that an empty layer defn is instanciated at layer creation.

Change History (5)

comment:1 by chaitanya, 14 years ago

Resolution: → fixed
Status: new → closed

Fixed and added a test in trunk in r19447. Also updated 1.7 (r19446) and 1.6 (r19448) branches.

comment:2 by Even Rouault, 14 years ago

Resolution: fixed
Status: closed → reopened

Chaitanya,

mitab_miffile.cpp belongs to the MITAB project. From a quick look, I think that upstream CVS MITAB hasn't incorporated the change you made in r19447 (the file is in version 1.52 in MITAB CVS whereas GDAL is still using 1.49). The normal proceedure is to upstream the change and then refresh GDAL from the CVS. You should see with Daniel so that he can incorporate your change.

comment:3 by aboudreault, 14 years ago

Please fill a bug on mitab bugzilla: ​http://bugzilla.maptools.org/enter_bug.cgi?product=MITAB I'll take care to include the patch in mitab.

comment:4 by Even Rouault, 14 years ago

Upstream ticket for MITAB filed by Chaitanya as ​http://bugzilla.maptools.org/show_bug.cgi?id=2180

comment:5 by aboudreault, 14 years ago

Resolution: → fixed
Status: reopened → closed

The change has been incorporated in mitab.

Note: See TracTickets for help on using tickets.