Ticket #3323 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

GRASS driver crash for location without projection

Reported by: rblazek Owned by: warmerdam
Priority: normal Milestone:
Component: GDAL_Raster Version: unspecified
Severity: normal Keywords: grass
Cc:

Description

QGIS bug  http://trac.osgeo.org/qgis/ticket/2303

It is just stupid bug in GRASS driver, G_free_key_value() called on NULL, patch attached.

May I submit to svn?

Attachments

grass57dataset.cpp.patch-noproj Download (0.6 KB) - added by rblazek 3 years ago.

Change History

Changed 3 years ago by rblazek

Changed 3 years ago by warmerdam

  • keywords grass added
  • component changed from default to GDAL_Raster

Radim,

Please go ahead, and it may be appropriate to backport to 1.6.

Changed 3 years ago by mloskot

Radim,

Wouldn't it be simpler to fix G_free_key_value function in GRASS to follow semantic of free() and do nothing for null pointer? The G_free in GRASS already does nothing for null pointer.

Changed 3 years ago by rblazek

  • status changed from new to closed
  • resolution set to fixed

It would be definitely good to fix also in GRASS lib but simpler no because you have to wait ages until it gets into distros.

Fixed in changeset:18537.

Changed 3 years ago by mloskot

Radim,

Understood, though I still suggest to apply the fix to GRASS as well. So, once new fixed version is released, messing 3rd parties code is no longer needed.

Changed 3 years ago by mloskot

The issue has been fixed in GRASS ( https://trac.osgeo.org/grass/ticket/866)

Note: See TracTickets for help on using tickets.