Ticket #3315 (closed defect: fixed)
VFK : errors reported by test_ogrsf utility
| Reported by: | rouault | Owned by: | martinl |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | OGR_SF | Version: | svn-trunk |
| Severity: | normal | Keywords: | VFK |
| Cc: | rouault |
Description
To check it : go in apps, and 'make test_ogrsf' then run test_ogrsf on your test .vfk file. This utility can be used to check the conformance of drivers to a few expected behaviours. Attached the report I got.
I've noticed a few errors, among them :
1) the ones about 'Feature SRS differs from layer SRS' are IMHO relatively minor. It means you need to do poGeom->assignSpatialReference(poSRS) as far as I remember
2) the one about 'GetFeatureCount?() may not be taking spatial filter into account' suggests that in your implementation of ::GetFeatureCount?(), you should propably default to call OGRLayer::GetFeatureCount?() when a spatial filter has been set. This will default to the dummy, but safe, implementation that iterates on all the features with GetNextFeature?() and count them
3) there's one : 'ERROR: Claimed feature count 13 doesn't match actual, 26.' . I'm not sure why. The test does a ResetReading?() and then iterate on GetNextFeature?() and compares the number of iterations to GetFeatureCount?(). Perhaps an issue with GetFeatureCount?() on that particular layer ?
Note: test_ogrsf was segfaulting because an old bug I've fixed in latest revision in r18471

