REPACK changes extension case and doesn't remove previous shapefile.

[jef]

shapefiles with uppercase extensions are not replaced by a REPACK. Instead the new shapefiles have lower case extensions and the old files are not deleted.

Running 2292.py:

from osgeo import ogr

ds = ogr.Open("2292.SHP", 1)
l = ds.GetLayerByIndex(0)
l.DeleteFeature(0)
ds.ExecuteSQL("REPACK 2292");

gives:

$ ls; python 2292.py; ls
2292.DBF  2292.PRJ  2292.SHP  2292.SHX  2292.py
2292.DBF  2292.PRJ  2292.SHP  2292.SHX  2292.dbf  2292.py  2292.shp  2292.shx

(as of python-gdal 1.6.3-1 in Debian unstable)

[jef]

See also ​http://trac.osgeo.org/qgis/ticket/2292 QGIS #2292

[Even Rouault]

r18334 /trunk/gdal/ogr/ogrsf_frmts/shape/ogrshapelayer.cpp: SHAPEFILE driver : Preserve file extensions in REPACK operation (#3293)

r18335 /branches/1.6/gdal/ogr/ogrsf_frmts/shape/ogrshapelayer.cpp: SHAPEFILE driver : Preserve file extensions in REPACK operation (#3293)

r18336 /trunk/autotest/ogr/ogr_shape.py: Test that REPACK preserves file extensions (#3293)

[Even Rouault]

The above commits also fixes memory leaks in error code paths, and a crash if a REPACK was attempted on a layer with only .shp and .shx, but no .dbf

[Mateusz Łoskot]

I've fixed a silly bug (r18897) I introduced myself a while ago which is perhaps related. Perhaps it should also go to 1.7.2 branch, I'm not sure.

[Even Rouault]

Mateusz,

Chaintanya will do the backport. Apparently, you missed part of the discussion on IRC. He was indeed about to fix the issue as he created ticket #3434. Well, better a bug fixed twice than ignored ;-).

[Mateusz Łoskot]

Even,

No, I did not miss that part. If st hits a fan and I'm a troublemaker, I want to clean it myself.

[Even Rouault]

Milestone 1.6.4 deleted