WKT Raster driver: FIXME. nodata is always read as a double

[jorgearevalo]

When reading nodata from database, we always get a double. Doesn't make sense to fetch less than 8 bytes.

See http://trac.osgeo.org/gdal/browser/trunk/gdal/frmts/wktraster/wktrasterwrapper.cpp#L257

[jorgearevalo]

I close this ticket. I forgot what spec says:

Nodata value: 1 to 8 bytes depending on pixtype.

So, I think is correct to read 1-8 bytes depending on pixeltype.

[jorgearevalo]

Ok, I was wrong. I reopen the ticket.

[rouault]

Jorge,

several points :

• it would be good if you could improve your commit messages. "Ticket XXX closed" is not descriptive enough of what the change is. I must open the ticket to actually see what it is about. I'd suggest something like "WKTRaster: always read nodata as double (#3231)"

• when you close a ticket, it is also good to make a reference to the commit that fixed it in a comment. Like "fixed in trunk in r18163". That way we have full tracability between the ticket and the commit.

• last one : in r18163, you've commited - I guess - undesirable changes in aclocal.m4 and configure. Could you please revert them ? Thanks

[jorgearevalo]

Ok Even. I realized on the error with configure and aclocal.m4, but I couldn't solve at that moment. Sorry and thanks for the tips!

[jorgearevalo]

The aclocal.m4 and configure files were restored. May I close this ticket?

[jorgearevalo]

Replying to jorgearevalo:

The aclocal.m4 and configure files were restored. May I close this ticket

[rouault]

Yes, that's fine. You don't need my confirmation when you are confident that things have been properly adressed. If I'm still unhappy, I'll reopen ;-)

[jorgearevalo]

Replying to rouault:

Yes, that's fine. You don't need my confirmation when you are confident that things have been properly adressed. If I'm still unhappy, I'll reopen ;-)

Understood :-)