Ticket #308 (assigned defect)

Opened 5 years ago

Last modified 7 months ago

Mapinfo : ogr symbol number problem

Reported by: dev@geoimage.fr Assigned to: dmorissette (accepted)
Priority: high Milestone:
Component: OGR_SF Version: unspecified
Severity: normal Keywords:
Cc: mloskot

Description (Last modified by mloskot)

In the mapinfo driver, the numbering of symbol does not match the numbering specified in the documentation : ogr-sym-X+1 is returned instead ogr-sym-X.

For example, ogr-sym-3 is returned for the filedd-circle symbol instead of ogr-sym-2.

Change History

02/21/04 11:33:03 changed by warmerdam 

Daniel, 

I would like this to be fixed before the GDAL/OGR 1.2.0 release if possible.
Do you know if it is correct?  What things are likely to be distrupted by
fixing this?  MapServer?  I think it will be good for OpenEV since it got
the symbols from the spec.

02/22/04 23:40:52 changed by dmorissette 

I think I understand why things have been done this way.  If you look at 
http://gdal.velocet.ca/~warmerda/projects/opengis/ogr_feature_style_008.html

You see that for PEN and BRUSH, index 0 is used for the default behavior (solid
line and solid fill), and #1 is used for null pen and null brush.

I suspect that there has been a revision to the style document where ogr-sym-1
has been changed to be a null symbol to follow the same logic, and that revision
would have been lost.  (Or Stephane just planned on doing that change to the
spec when he wrote that code and never got to it.)

I don't think that changing the code would cause much harm to MapServer users,
but for consistency we may be better updating the ogr_feature_style document.

Is OpenEV the only app that uses those codes?  How much trouble would it be to
change it to use the fixed codes?

12/22/07 04:03:50 changed by mloskot

  • cc set to mloskot.
  • description changed.