Opened 8 years ago

Closed 5 years ago

#3025 closed defect (fixed)

OCI: Layer dimension not well detected on Oracle when 2D and 3D layers exists

Reported by: Nicolas Simon Owned by: ilucena
Priority: normal Milestone:
Component: OGR_SF Version: 1.8.1
Severity: normal Keywords: OCI
Cc: ealpert@…

Description

Hello,

When Oracle DB contains 2d and 3d layers, layer dimension is not well detected.

You can find a patched version of ogrocitablelayer.cpp that detect the right layer dimension. The new code is between line 244 and line 281 of the provided file.

Is it possible to include this fix in 1.6.2 release ?

Thank you

Nicolas Simon

Attachments (5)

ogrocitablelayer.cpp (66.6 KB) - added by Nicolas Simon 8 years ago.
OCIWrite3025.diff (1.6 KB) - added by Nicolas Simon 8 years ago.
Patch file against main trunk
create_table.sql (2.7 KB) - added by Nicolas Simon 8 years ago.
Table creation to view the problem
test_read2D.cpp (1.0 KB) - added by Nicolas Simon 8 years ago.
Table creation to view the problem
OCIRead3025.diff (5.9 KB) - added by Nicolas Simon 8 years ago.
Patch file against main trunk for Read access

Download all attachments as: .zip

Change History (13)

Changed 8 years ago by Nicolas Simon

Attachment: ogrocitablelayer.cpp added

Changed 8 years ago by Nicolas Simon

Attachment: OCIWrite3025.diff added

Patch file against main trunk

Changed 8 years ago by Nicolas Simon

Attachment: create_table.sql added

Table creation to view the problem

Changed 8 years ago by Nicolas Simon

Attachment: test_read2D.cpp added

Table creation to view the problem

Changed 8 years ago by Nicolas Simon

Attachment: OCIRead3025.diff added

Patch file against main trunk for Read access

comment:1 Changed 8 years ago by Nicolas Simon

Hello,

Please, no longer consider ogrocitablelayer.cpp

The 2 patchs files (OCIWrite3025.diff and OCIRead3025.diff) solve respectively the first and the second point evoked

on gdal-dev@… with topic "OGR OCI Driver improvement about CoordinateDimension?" (5 august 2009 14:55)

Nicolas Simon

comment:2 Changed 8 years ago by warmerdam

Milestone: 1.6.4
Owner: changed from warmerdam to ilucena

Ivan,

Could you review and consider?

comment:3 Changed 8 years ago by warmerdam

Keywords: OCI added

comment:4 Changed 7 years ago by ilucena

That was fixed on ticket #1960.

comment:5 Changed 7 years ago by ilucena

Resolution: fixed
Status: newclosed

comment:6 Changed 6 years ago by ilucena

Cc: ealpert@… added
Resolution: fixed
Status: closedreopened
Version: 1.6.11.8.1

Reopen based on this post on gdal-dev:

http://lists.osgeo.org/pipermail/gdal-dev/2011-September/030199.html

The changes on #1960 does not address that issue.

comment:7 Changed 6 years ago by ilucena

Fixed on revision r23102

http://trac.osgeo.org/gdal/changeset/23102/trunk

It has passed all the autotest for this driver but please, confirm that it solved your problem so I can close that ticket.

Thanks.

comment:8 Changed 5 years ago by Nicolas Simon

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.