Build failure with gcc 4.4

[frankie]

See ​http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=505629 for a missing header.

[warmerdam]

The essentials from this link are:

Your package fails to build with the upcoming GCC 4.4. Version 4.4 has not been released yet but I'm building with a snapshot in order to find errors and give people an advance warning.

GCC 4.4 cleaned up some more C++ headers. You always have to #include headers directly and cannot rely for things to be included indirectly.

You can reproduce this problem with gcc-snapshot from unstable.

> Automatic build of gdal_1.5.2-3 on em64t by sbuild/amd64 0.53
...
> /bin/sh /build/tbm/gdal-1.5.2/libtool --mode=compile --tag=CXX g++ -g -O2  -Wall  -I/usr/include -I/usr/include/xercesc -DOGR_ENABLED -I/build/tbm/gdal-1.5.2/port  -I.. -c -o ../../o/iom_utilities.o iom_utilities.cpp
>  g++ -g -O2 -Wall -I/usr/include -I/usr/include/xercesc -DOGR_ENABLED -I/build/tbm/gdal-1.5.2/port -I.. -c iom_utilities.cpp  -fPIC -DPIC -o ../../o/.libs/iom_utilities.o
> iom_utilities.cpp: In function 'char* iom_gettmpnam()':
> iom_utilities.cpp:230: error: 'tempnam' was not declared in this scope
> make[5]: *** [../../o/iom_utilities.o] Error 1
> make[5]: Leaving directory `/build/tbm/gdal-1.5.2/ogr/ogrsf_frmts/ili/iom'

--- ogr/ogrsf_frmts/ili/iom/iom_utilities.cpp~	2008-11-13 22:02:15.000000000 +0000
+++ ogr/ogrsf_frmts/ili/iom/iom_utilities.cpp	2008-11-13 22:02:21.000000000 +0000
@@ -33,6 +33,7 @@
  * @{
  */
 
+#include <cstdio>
 #include <iostream>
 #include <string>
 #include <string.h>

Chaitanya,

Please look into adding this include in trunk, 1.6 branch and 1.5 branch as appropriate.

I have added Pirmin as a cc: in case he sees a need to upstream this change or has any other comment.

[Even Rouault]

Francesco,

you already submitted this bug report as #2690 and it was fixed in 1.5.4. See http://trac.osgeo.org/gdal/browser/tags/1.5.4/gdal/ogr/ogrsf_frmts/ili/iom/iom_utilities.cpp and http://trac.osgeo.org/gdal/wiki/Release/1.5.4-News.