postgres driver failes to create geometry index if layer name starts with a number

[winkey]

ERROR 1: 'CREATE INDEX 500hgt_geom_idx ON "public"."500hgt" USING GIST ("wkb_geometry")' failed for layer 500hgt, layer creation has failed.

index name needs to be quoted

in ogrpgdatasource.cpp around line 1291

            osCommand.Printf("CREATE INDEX %s_geom_idx ON \"%s\".\"%s\" USING GIST (\"%s\")",
                    pszTableName, pszSchemaName, pszTableName, pszGFldName);

should be

            osCommand.Printf("CREATE INDEX \"%s_geom_idx\" ON \"%s\".\"%s\" USING GIST (\"%s\")",
                    pszTableName, pszSchemaName, pszTableName, pszGFldName);

[warmerdam]

Chaitanya,

Please setup a postgis database for testing (if you don't already have one), confirm the problem, confirm the fix and apply in trunk and 1.6.

[chaitanya]

Committed to trunk (r16765) and 1.6 (r16766)

[rouault]

Additionnal quoting for geometry and FID columns added in trunk (r16807) and branches/1.6 (r16808). Test added in r16809