Opened 15 years ago

Closed 15 years ago

#2685 closed defect (fixed)

Complete documentation of the OGRLayer::TestCapability() method

Reported by: dron Owned by: warmerdam
Priority: normal Milestone:
Component: Docs Version: svn-trunk
Severity: normal Keywords:
Cc:

Description

There are number of possible capability values that are not documented in OGRLayer::TestCapability() method (see ​http://www.gdal.org/ogr/classOGRLayer.html#eedbda1a62f9b89b8e5f24332cf22286). They are: OLCCreateField, OLCTransactions, OLCDeleteFeature, OLCStringsAsUTF8.

The question came when reviewing the SQLite driver sources. The TestCapabilty() method looks like that: 

int OGRSQLiteLayer::TestCapability( const char * pszCap )

{
    if( EQUAL(pszCap,OLCRandomRead) )
        return FALSE;

    else if( EQUAL(pszCap,OLCFastFeatureCount) )
        return FALSE;

    else if( EQUAL(pszCap,OLCFastSpatialFilter) )
        return FALSE;

    else if( EQUAL(pszCap,OLCTransactions) )
        return FALSE;

    else 
        return FALSE;
}

It seems to me that OLCTransactions should return TRUE because there are support for transactions in the driver. But it is possible I am just got something wrong, so there is a need in documentation on that.

Change History (1)

comment:1 by warmerdam, 15 years ago

Resolution: → fixed
Status: new → closed

added docs for missing capabilities in trunk (r15953).

Note: See TracTickets for help on using tickets.