Wrong ifndef

[frankie]

http://trac.osgeo.org/gdal/browser/trunk/gdal/swig/python/GNUmakefile?rev=13720

ifndef PYTHON

thanks

[warmerdam]

Howard, perhaps you will know what this is about?

[frankie]

Of course this is an issue also in 1.5.1. See  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=474963 for effects when building for multiple python versions.

[hobu]

Frankie,

Could you provide a little more detail why this is a problem? If you ./configure --with-python=the/python/i/care/about, this ifndef will be false. It is set to just be a generic python when none is defined, and its need for being set was an artifact of #2182

[frankie]

Replying to hobu:

Frankie, Could you provide a little more detail why this is a problem? If you ./configure --with-python=the/python/i/care/about, this ifndef will be false. It is set to just be a generic python when none is defined, and its need for being set was an artifact of #2182

The makefile syntax is (was?) simply wrong.

diff -urNad gdal-1.5.1~/swig/python/GNUmakefile gdal-1.5.1/swig/python/GNUmakefile --- gdal-1.5.1~/swig/python/GNUmakefile 2008-04-19 13:12:54.000000000 +0200 +++ gdal-1.5.1/swig/python/GNUmakefile 2008-04-19 13:21:27.000000000 +0200 @@ -2,7 +2,7 @@

include ../../GDALmake.opt

-ifndef $(PYTHON) +ifndef PYTHON

PYTHON=python

endif

[frankie]

Bah, damn forms ...

See  http://svn.debian.org/viewsvn/pkg-grass/packages/gdal/trunk/debian/patches/pythonmakefile.dpatch?rev=1546&view=auto for the patch

[hobu]

Fixed in r14583.

[frankie]

Still not fixed in 1.5 branch, anyway.

[rouault]

Backported to branches/1.5 in r15045. Will be 1.5.3