Ticket #2333 (reopened defect)

Opened 3 months ago

Last modified 1 month ago

Wrong ifndef

Reported by: frankie Assigned to: hobu
Priority: normal Milestone:
Component: ConfigBuild Version: 1.5.2
Severity: normal Keywords:
Cc:

Description

http://trac.osgeo.org/gdal/browser/trunk/gdal/swig/python/GNUmakefile?rev=13720

ifndef PYTHON

thanks

Change History

04/19/08 08:20:39 changed by warmerdam

  • owner changed from warmerdam to hobu.
  • component changed from default to ConfigBuild.

Howard, perhaps you will know what this is about?

04/19/08 13:16:44 changed by frankie

Of course this is an issue also in 1.5.1. See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=474963 for effects when building for multiple python versions.

(follow-up: ↓ 4 ) 05/30/08 23:39:27 changed by hobu

Frankie,

Could you provide a little more detail why this is a problem? If you ./configure --with-python=the/python/i/care/about, this ifndef will be false. It is set to just be a generic python when none is defined, and its need for being set was an artifact of #2182

(in reply to: ↑ 3 ) 05/31/08 03:34:46 changed by frankie

Replying to hobu:

Frankie, Could you provide a little more detail why this is a problem? If you ./configure --with-python=the/python/i/care/about, this ifndef will be false. It is set to just be a generic python when none is defined, and its need for being set was an artifact of #2182

The makefile syntax is (was?) simply wrong.

diff -urNad gdal-1.5.1~/swig/python/GNUmakefile gdal-1.5.1/swig/python/GNUmakefile --- gdal-1.5.1~/swig/python/GNUmakefile 2008-04-19 13:12:54.000000000 +0200 +++ gdal-1.5.1/swig/python/GNUmakefile 2008-04-19 13:21:27.000000000 +0200 @@ -2,7 +2,7 @@

include ../../GDALmake.opt

-ifndef $(PYTHON) +ifndef PYTHON

PYTHON=python

endif

05/31/08 03:36:46 changed by frankie

Bah, damn forms ...

See http://svn.debian.org/viewsvn/pkg-grass/packages/gdal/trunk/debian/patches/pythonmakefile.dpatch?rev=1546&view=auto for the patch

05/31/08 03:41:40 changed by hobu

  • status changed from new to closed.
  • resolution set to fixed.

Fixed in r14583.

06/10/08 11:00:05 changed by frankie

  • version changed from svn-trunk to 1.5.2.

Still not fixed in 1.5 branch, anyway.

06/10/08 11:00:28 changed by frankie

  • status changed from closed to reopened.
  • resolution deleted.