Ticket #2333 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

Wrong ifndef

Reported by: frankie Owned by: hobu
Priority: normal Milestone: 1.5.3
Component: ConfigBuild Version: 1.5.2
Severity: normal Keywords:
Cc:

Change History

  Changed 5 years ago by warmerdam

  • owner changed from warmerdam to hobu
  • component changed from default to ConfigBuild

Howard, perhaps you will know what this is about?

  Changed 5 years ago by frankie

Of course this is an issue also in 1.5.1. See  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=474963 for effects when building for multiple python versions.

follow-up: ↓ 4   Changed 5 years ago by hobu

Frankie,

Could you provide a little more detail why this is a problem? If you ./configure --with-python=the/python/i/care/about, this ifndef will be false. It is set to just be a generic python when none is defined, and its need for being set was an artifact of #2182

in reply to: ↑ 3   Changed 5 years ago by frankie

Replying to hobu:

Frankie, Could you provide a little more detail why this is a problem? If you ./configure --with-python=the/python/i/care/about, this ifndef will be false. It is set to just be a generic python when none is defined, and its need for being set was an artifact of #2182

The makefile syntax is (was?) simply wrong.

diff -urNad gdal-1.5.1~/swig/python/GNUmakefile gdal-1.5.1/swig/python/GNUmakefile --- gdal-1.5.1~/swig/python/GNUmakefile 2008-04-19 13:12:54.000000000 +0200 +++ gdal-1.5.1/swig/python/GNUmakefile 2008-04-19 13:21:27.000000000 +0200 @@ -2,7 +2,7 @@

include ../../GDALmake.opt

-ifndef $(PYTHON) +ifndef PYTHON

PYTHON=python

endif

  Changed 5 years ago by hobu

  • status changed from new to closed
  • resolution set to fixed

Fixed in r14583.

  Changed 5 years ago by frankie

  • version changed from svn-trunk to 1.5.2

Still not fixed in 1.5 branch, anyway.

  Changed 5 years ago by frankie

  • status changed from closed to reopened
  • resolution fixed deleted

  Changed 5 years ago by rouault

  • status changed from reopened to closed
  • resolution set to fixed
  • milestone set to 1.5.3

Backported to branches/1.5 in r15045. Will be 1.5.3

Note: See TracTickets for help on using tickets.