Opened 11 years ago

Closed 3 years ago

#2232 closed defect (wontfix)

[PATCH] Cleanup of COASP driver

Reported by: Even Rouault Owned by: pvachon
Priority: normal Milestone:
Component: GDAL_Raster Version: unspecified
Severity: normal Keywords:
Cc: antonio

Description

Phil,

In a general effort of reviewing GDAL code with a "security" point of view, I've made some cleanups and fixes in the COASP driver. Could you review and test the attached patch as I've no real COASP dataset available. I just hand-crafted a fake dataset by reading your code to test it but that's just poor man testing ;-)

I made some cuts in the code dealing with GCP as it seems not to be really implemented and there were strange things from the C++ inheritance point of view.

I'm afraid the patch is unreadable due to indentation fixes, so I've attached the new version of the file too.

Attachments (2)

gdal_svn_trunk_coasp_cleanup.patch (21.8 KB) - added by Even Rouault 11 years ago.
coasp_dataset.cpp (16.7 KB) - added by Even Rouault 11 years ago.
Modified version of coasp_dataset.cpp after appyling the patch

Download all attachments as: .zip

Change History (6)

Changed 11 years ago by Even Rouault

Changed 11 years ago by Even Rouault

Attachment: coasp_dataset.cpp added

Modified version of coasp_dataset.cpp after appyling the patch

comment:1 Changed 11 years ago by Even Rouault

After chatting with Phil, this driver is under major rewrite. So the patch must not be applied as such.

comment:2 Changed 8 years ago by antonio

Cc: antonio added

comment:3 Changed 4 years ago by Jukka Rahkonen

Major rewrite under construction for 7 years now. Is it likely that this patch will ever be applied?

comment:4 Changed 3 years ago by Jukka Rahkonen

Resolution: wontfix
Status: newclosed

New patch did not happen, closing.

Note: See TracTickets for help on using tickets.