Ticket #2198 (new defect)

Opened 5 months ago

Last modified 5 months ago

Incorrect condition checking Visual C++ version in cpl_string.h

Reported by: mloskot Assigned to: mloskot
Priority: normal Milestone: 1.6.0
Component: default Version: svn-trunk
Severity: normal Keywords: cpl port string vc6
Cc: warmerdam

Description (Last modified by mloskot)

In file cpl_string.h, #ifdef condition at line 160 should be changed from: 

if (_MSC_VER <= 1202)
#  define MSVC_OLD_STUPID_BEHAVIOUR
#endif

to read 

#if defined(_MSC_VER)
#  if (_MSC_VER <= 1202)
#    define MSVC_OLD_STUPID_BEHAVIOUR
#  endif
#endif

This problem is also related to discussion about #2179

Patch attached.

Attachments

port-cpl_string.h-string-mloskot.patch (1.0 kB) - added by mloskot on 02/05/08 11:15:32.
The #ifdef condition fix for Visual C++ 6.0

Change History

02/05/08 11:15:32 changed by mloskot

  • attachment port-cpl_string.h-string-mloskot.patch added.

The #ifdef condition fix for Visual C++ 6.0

02/05/08 11:15:46 changed by mloskot

  • keywords changed from cpl port string to cpl port string vc6.

02/05/08 11:16:40 changed by mloskot

  • description changed.

02/05/08 11:19:36 changed by warmerdam

  • owner changed from warmerdam to mloskot.
  • cc set to warmerdam.
  • milestone set to 1.6.0.

Mateusz,

Feel free to apply this in trunk after we have finished testing my last patch for #2179.