Ticket #2198 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

Incorrect condition checking Visual C++ version in cpl_string.h

Reported by: mloskot Owned by: mloskot
Priority: normal Milestone: 1.6.0
Component: default Version: svn-trunk
Severity: normal Keywords: cpl port string vc6
Cc: warmerdam

Description (last modified by mloskot) (diff)

In file cpl_string.h, #ifdef condition at line 160 should be changed from: 

if (_MSC_VER <= 1202)
#  define MSVC_OLD_STUPID_BEHAVIOUR
#endif

to read 

#if defined(_MSC_VER)
#  if (_MSC_VER <= 1202)
#    define MSVC_OLD_STUPID_BEHAVIOUR
#  endif
#endif

This problem is also related to discussion about #2179

Patch attached.

Attachments

port-cpl_string.h-string-mloskot.patch Download (1.0 KB) - added by mloskot 5 years ago.
The #ifdef condition fix for Visual C++ 6.0

Change History

Changed 5 years ago by mloskot

The #ifdef condition fix for Visual C++ 6.0

Changed 5 years ago by mloskot

  • keywords vc6 added

Changed 5 years ago by mloskot

  • description modified (diff)

Changed 5 years ago by warmerdam

  • cc warmerdam added
  • owner changed from warmerdam to mloskot
  • milestone set to 1.6.0

Mateusz,

Feel free to apply this in trunk after we have finished testing my last patch for #2179.

Changed 5 years ago by mloskot

  • owner changed from mloskot to mloskot
  • status changed from new to assigned

Changed 5 years ago by mloskot

  • status changed from assigned to closed
  • resolution set to fixed

Patch has been applied to trunk (r14851). Closing.

Changed 5 years ago by mloskot

Second Unix-specific part of the patch (r14852)

Note: See TracTickets for help on using tickets.