Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#2198 closed defect (fixed)

Incorrect condition checking Visual C++ version in cpl_string.h

Reported by: Mateusz Łoskot Owned by: Mateusz Łoskot
Priority: normal Milestone: 1.6.0
Component: default Version: svn-trunk
Severity: normal Keywords: cpl port string vc6
Cc: warmerdam

Description (last modified by Mateusz Łoskot)

In file cpl_string.h, #ifdef condition at line 160 should be changed from:

if (_MSC_VER <= 1202)
#  define MSVC_OLD_STUPID_BEHAVIOUR
#endif

to read

#if defined(_MSC_VER)
#  if (_MSC_VER <= 1202)
#    define MSVC_OLD_STUPID_BEHAVIOUR
#  endif
#endif

This problem is also related to discussion about #2179

Patch attached.

Attachments (1)

port-cpl_string.h-string-mloskot.patch (1.0 KB) - added by Mateusz Łoskot 12 years ago.
The #ifdef condition fix for Visual C++ 6.0

Download all attachments as: .zip

Change History (7)

Changed 12 years ago by Mateusz Łoskot

The #ifdef condition fix for Visual C++ 6.0

comment:1 Changed 12 years ago by Mateusz Łoskot

Keywords: vc6 added

comment:2 Changed 12 years ago by Mateusz Łoskot

Description: modified (diff)

comment:3 Changed 12 years ago by warmerdam

Cc: warmerdam added
Milestone: 1.6.0
Owner: changed from warmerdam to Mateusz Łoskot

Mateusz,

Feel free to apply this in trunk after we have finished testing my last patch for #2179.

comment:4 Changed 11 years ago by mloskot

Status: newassigned

comment:5 Changed 11 years ago by mloskot

Resolution: fixed
Status: assignedclosed

Patch has been applied to trunk (r14851). Closing.

comment:6 Changed 11 years ago by mloskot

Second Unix-specific part of the patch (r14852)

Note: See TracTickets for help on using tickets.