Opened 12 years ago

Closed 12 years ago

#2186 closed defect (fixed)

GDAL C# Bindings are not strong named

Reported by: jbeverage Owned by: tamas
Priority: normal Milestone:
Component: CSharpBindings Version: 1.5.0
Severity: normal Keywords:
Cc:

Description

I've been using the C# wrappers that come with FWTools, and I noticed that they are not strongly named. This is causing a problem for my project as we require everything to be strongly named.

I noticed that the makefile.vc has a "sign" step that generates the gdal.snk file, but it is not used after that.

If you change the gdal_csharp target to include the /keyfile argument, it should produce strongly named assemblies: $(CSC) /debug:full /keyfile:gdal.snk /target:library /out:ogr_csharp.dll ogr\*.cs $(CSC) /debug:full /keyfile:gdal.snk /target:library /out:gdal_csharp.dll gdal\*.cs $(CSC) /debug:full /keyfile:gdal.snk /target:library /out:gdalconst_csharp.dll const\*.cs $(CSC) /debug:full /keyfile:gdal.snk /target:library /out:osr_csharp.dll osr\*.cs

It would be great if the bindings that come from the FWTools distro become the "official" way to download the binaries and they are signed when we get them.

Change History (2)

comment:1 Changed 12 years ago by tamas

Status: newassigned

Added the strong name support in SVN trunk r13646 We are using a fixed keyfile that won't change among the releases. gdal.snk have also been added to the repository. The keyfile is referenced by AssemblyInfo?.cs that might be deprecated by the further Visual Studio releases. However this is the only way to support the strongnames for all of the platforms right now.

I'm waiting for a positive feedback before closing this bug

comment:2 Changed 12 years ago by tamas

Resolution: fixed
Status: assignedclosed

Closing.

Note: See TracTickets for help on using tickets.