terragen: overflow in implicit constant conversion

[rouault]

When compiling GDAL (1.5, and 1.4.X probably), the following warning is emitted :

terragendataset.cpp: In constructor 'TerragenDataset::TerragenDataset()':
terragendataset.cpp:463: warning: overflow in implicit constant conversion

Declaration : GInt16 m_nHeightScale;

Initialization: m_nHeightScale = 65536;

Hence the warning.

[mloskot]

It should be safe to change the type from 16-bit to 32-bit integer. Or to change from signed 16-bit integer to unsigned that ranges from 0 to 65535 assuming value 65536 is wrong :-)

[rayg]

heightscale init'd to zero. Type must be Gint16; is data file field.

[mloskot]

rayg,

Is the r13440 changeset related to this bug? Please, may I ask for providing commit message that includes, at least, ticket number that submission refers too? Thanks!

[rayg]

Yeah, sorry about that... I realized I'd forgotten to comment just after I checked the file in. I'm used to scc systems that prompt for comments.

[mloskot]

No problem, thanks!