Ticket #2104 (closed defect: fixed)

Opened 9 months ago

Last modified 9 months ago

RS2 Driver 8-bit support

Reported by: allanx13 Assigned to: warmerdam
Priority: normal Milestone: 1.5.1
Component: GDAL_Raster Version: unspecified
Severity: normal Keywords: rs2
Cc: pvachon

Description

Currently, the RS2 driver supports only 16-bit complex and 16-bit magnitude products. I have a simulated RADARSAT-2 ScanSAR Wide A 8-bit image with data type "Magnitude". Adding the following lines at line 620 of rs2dataset.cpp (before the "else" statement) allows me to read this image:

else if( nBitsPerSample == 8 && EQUALN(pszDataType,"Mag",3) )

eDataType = GDT_Byte;

Unless there are any issues with 8-bit imagery in this driver, could you add this?

Change History

12/18/07 16:43:16 changed by warmerdam

  • keywords set to rs2.
  • status changed from new to closed.
  • resolution set to fixed.
  • cc set to philv.
  • milestone set to 1.5.0.

Patch applied (r13367), minutes before I begin work snapping 1.5.0RC1!

12/18/07 19:32:17 changed by pvachon

  • status changed from closed to reopened.
  • cc changed from philv to pvachon.
  • resolution deleted.

This fix is not enough. The RS2*RasterBand? classes are only GDT_[C]Int16 aware.

I will submit a fix against TRUNK shortly that will fix this.

12/18/07 19:58:45 changed by pvachon

  • status changed from reopened to closed.
  • resolution set to fixed.

Fixed in r13373 in TRUNK. I will ask Frank if he minds applying these fixes to the 1.5.0 release candidate. Otherwise, we'll have to wait until 1.5.1 (but if you're working against trunk, it probably is a non-issue).

12/18/07 20:33:18 changed by warmerdam

  • milestone changed from 1.5.0 to 1.5.1.

I don't consider this issue sufficient to break interrupt the release candidate. But I have merged the fix into 1.5 branch (r13375).