#2104 closed defect (fixed)
RS2 Driver 8-bit support
Reported by: | allanx13 | Owned by: | warmerdam |
---|---|---|---|
Priority: | normal | Milestone: | 1.5.1 |
Component: | GDAL_Raster | Version: | unspecified |
Severity: | normal | Keywords: | rs2 |
Cc: | pvachon |
Description
Currently, the RS2 driver supports only 16-bit complex and 16-bit magnitude products. I have a simulated RADARSAT-2 ScanSAR Wide A 8-bit image with data type "Magnitude". Adding the following lines at line 620 of rs2dataset.cpp (before the "else" statement) allows me to read this image:
else if( nBitsPerSample == 8 && EQUALN(pszDataType,"Mag",3) )
eDataType = GDT_Byte;
Unless there are any issues with 8-bit imagery in this driver, could you add this?
Change History (4)
comment:1 by , 16 years ago
Cc: | added |
---|---|
Keywords: | rs2 added |
Milestone: | → 1.5.0 |
Resolution: | → fixed |
Status: | new → closed |
comment:2 by , 16 years ago
Cc: | added; removed |
---|---|
Resolution: | fixed |
Status: | closed → reopened |
This fix is not enough. The RS2*RasterBand classes are only GDT_[C]Int16 aware.
I will submit a fix against TRUNK shortly that will fix this.
comment:3 by , 16 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Fixed in r13373 in TRUNK. I will ask Frank if he minds applying these fixes to the 1.5.0 release candidate. Otherwise, we'll have to wait until 1.5.1 (but if you're working against trunk, it probably is a non-issue).
comment:4 by , 16 years ago
Milestone: | 1.5.0 → 1.5.1 |
---|
I don't consider this issue sufficient to break interrupt the release candidate. But I have merged the fix into 1.5 branch (r13375).
Patch applied (r13367), minutes before I begin work snapping 1.5.0RC1!