Ticket #1743 (closed enhancement: wontfix)

Opened 6 years ago

Last modified 3 years ago

Const correctness in cpl_http module

Reported by: mloskot Owned by: mloskot
Priority: normal Milestone:
Component: default Version: svn-trunk
Severity: normal Keywords: const-correctness http
Cc:

Description

AFAIR, the cpl_http.h|cpp module is quite new and not widely used across GDAL components. I'd suggest to review it and fix const-correctness of input parameters. For instance, function CPLHTTPFetch takes char** papszOptions but this parameters is (conceptually) read-only. So, my suggestion is to change the prototype of CPLHTTPFetch to: 

CPLHTTPResult CPLHTTPFetch(const char* pszUrl, const char* const* papszOptions);

 Here is an example of potential problems related to the issue reported in this ticket.

Change History

Changed 3 years ago by mloskot

  • owner changed from warmerdam to mloskot
  • status changed from new to assigned

Changed 3 years ago by mloskot

  • status changed from assigned to closed
  • resolution set to wontfix

No feedback, no interest, giving up.

Note: See TracTickets for help on using tickets.