Ticket #1734 (closed defect: fixed)

Opened 1 year ago

Last modified 7 months ago

[PATCH] Fix documentation related to worldfile extensions and add a few more extensions

Reported by: rouault Assigned to: warmerdam
Priority: normal Milestone: 1.6.0
Component: GDAL_Raster Version: 1.4.2
Severity: normal Keywords: worldfile extensions
Cc:

Description

Some trivial patches to add a few more worldfile extensions and make documentation consistent :

  • JPEG : Add support for '.jpw' and '.jpegw'. Documentation didn't mention '.jpgw' which was supported. Updated with '.jpw' and '.jpegw'
  • BMP : Add support for '.bpw'. Documentation didn't mention support for worlfile. Fixed
  • GIF : Add support for '.gifw'. Documentation didn't mention '.gfw' which was supported. Updated, and with '.gifw' also.
  • PNG. This one is a bit weird. Code and documentation mention tfw and tifw ?? Patch to replace them with '.pgw' and '.pngw'
  • TIF. Add support for '.tiffw'. Documention didn't mention '.tifw' which was supported, but '.tiffw' which wasn't... Updated.

That's all !

Attachments

gdal-1.4.2-bmp-worldfile-extensions.patch (1.2 kB) - added by rouault on 08/04/07 12:23:13.
gdal-1.4.2-gif-worldfile-extensions.patch (1.3 kB) - added by rouault on 08/04/07 12:23:30.
gdal-1.4.2-jpg-worldfile-extensions.patch (1.6 kB) - added by rouault on 08/04/07 12:23:39.
gdal-1.4.2-png-worldfile-extensions.patch (1.6 kB) - added by rouault on 08/04/07 12:23:47.
gdal-1.4.2-tif-worldfile-extensions.patch (1.3 kB) - added by rouault on 08/04/07 12:23:56.

Change History

08/04/07 12:23:13 changed by rouault

  • attachment gdal-1.4.2-bmp-worldfile-extensions.patch added.

08/04/07 12:23:30 changed by rouault

  • attachment gdal-1.4.2-gif-worldfile-extensions.patch added.

08/04/07 12:23:39 changed by rouault

  • attachment gdal-1.4.2-jpg-worldfile-extensions.patch added.

08/04/07 12:23:47 changed by rouault

  • attachment gdal-1.4.2-png-worldfile-extensions.patch added.

08/04/07 12:23:56 changed by rouault

  • attachment gdal-1.4.2-tif-worldfile-extensions.patch added.

08/17/07 14:42:28 changed by warmerdam

I'd like to hold these changes a bit. Some of the additions (ie. .bmw) do not seem like a good idea. The "rule" for world file naming is supposed to be that the full unix name is the old extension with "w" added. The windows 3 character extension is the first and last character of the original extension with "w" added.

I don't like adding unnecessary checks because each variation results in addition open() calls to the filesystem.

If NULL is passed as the extension to GDALReadWorldFile() it will apply the standard rules. It may well be that these drivers can be simplified to depend on that behavior.

02/16/08 11:10:36 changed by rouault

  • status changed from new to closed.
  • resolution set to fixed.
  • milestone set to 1.6.0.

In r13801, I've commited a few changes in code and documentaion that should harmonize how ESRI world file extensions are handled. First, a GDALReadWorldFile() call is made with the NULL argument to check the .bpw or .bmpw for a .bmp file for example, and then a GDALReadWorldFile with the default .wld extension.