Ticket #1718 (closed defect: fixed)

Opened 1 year ago

Last modified 11 months ago

OSR ExportToProj4 causes a setfault with an empty reference

Reported by: hobu Assigned to: warmerdam
Priority: normal Milestone: 1.4.3
Component: OGR_SRS Version: svn-trunk
Severity: normal Keywords: proj4
Cc: mloskot

Description (Last modified by hobu) 

import osr
ref = osr.SpatialReference()

# download some junk
ref.SetFromUserInput('http://spatialreference.org/user/6')

# no problem here
print ref.ExportToWkt()

# goes splat here
print ref.ExportToProj4()

0x024f48b9 in OGR_SRSNode::GetValue (this=0x0) at /Users/hobu/svn/gdal/ogr/ogr_spatialref.h:90
90          const char  *GetValue() const { return pszValue; }
(gdb) bt
#0  0x024f48b9 in OGR_SRSNode::GetValue (this=0x0) at /Users/hobu/svn/gdal/ogr/ogr_spatialref.h:90
#1  0x0236d764 in OGRSpatialReference::exportToProj4 (this=0x30b870, ppszProj4=0xbffff518) at ogr_srs_proj4.cpp:957
#2  0x023730e1 in OSRExportToProj4 (hSRS=0x30b870, ppszReturn=0xbffff518) at ogr_srs_proj4.cpp:919
#3  0x0020c324 in _wrap_SpatialReference_ExportToProj4 (args=0x79f50) at osr_wrap.cpp:3271
#4  0x97eb67fe in PyObject_Call ()
#5  0x97f07450 in _PyEval_SliceIndex ()
#6  0x97f08a98 in PyEval_EvalCodeEx ()
#7  0x97f06f6d in _PyEval_SliceIndex ()
#8  0x97f08a98 in PyEval_EvalCodeEx ()
#9  0x97f08bbb in PyEval_EvalCode ()
#10 0x97f21dc5 in PyErr_Display ()
#11 0x97f2395a in PyRun_SimpleFileExFlags ()
#12 0x97f2b42b in Py_Main ()
#13 0x00001f8e in start ()
Current language:  auto; currently c++

Change History

07/30/07 10:10:10 changed by hobu

  • description changed.

07/30/07 11:03:38 changed by warmerdam

  • status changed from new to closed.
  • component changed from default to OGR_SRS.
  • version changed from unspecified to 1.4.0.
  • milestone changed from 1.5.0 to 1.4.3.
  • keywords set to proj4.
  • resolution set to fixed.

The problem was introduced in 1.4.0 with the EXTENSION[] mechanism. I have corrected it in 1.4 and trunk branches.

Also added an error catch for unrecognised projection strings in trunk.

Also added tests for these cases in gdalautotest/osr/osr_proj4.py.

08/13/07 15:22:49 changed by mloskot

The old Python bindings still throw segmentation fault. The problem is in gdal_wrap.c:2388, OGRFree(wkt) is called for data allocated on stack (wkt = "").

Here is possible fix: {{[ err = OSRExportToProj4( _arg0, &wkt ); if( wkt == NULL ) {

ret = Py_BuildValue( "s", wkt ); OGRFree( wkt );

} else {

ret = Py_BuildValue( "s", "" );

} }}}

08/13/07 15:23:30 changed by mloskot

  • cc set to mloskot.

08/15/07 10:17:34 changed by mloskot

  • status changed from closed to reopened.
  • resolution deleted.

08/15/07 10:18:01 changed by mloskot

  • status changed from reopened to new.
  • owner changed from warmerdam to mloskot.

Taking this bug to apply termporary fix to gdal.i.

08/15/07 10:20:16 changed by mloskot

  • status changed from new to assigned.

First, I applied the fix to gdal_wrap.c first, so I was able to test it using the buildbot (r11883). Next, I fixed gdal.i (r11884) and now it's needed to regenerate gdal_wrap.c to apply the fix permanently.

08/15/07 10:22:27 changed by mloskot

  • status changed from assigned to new.
  • owner changed from mloskot to warmerdam.

Reassigned back to Frank to regenerate the gdal_wrap.c file.

08/15/07 10:22:50 changed by mloskot

  • version changed from 1.4.0 to svn-trunk.

08/20/07 13:00:07 changed by warmerdam

  • status changed from new to closed.
  • resolution set to fixed.

gdal_wrap.c regenerated with SWIG 1.1pl5. I also updated the GNUmakefile to use the command name swig11pl5 to emphasize the version required.