Ticket #1691 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

GDALOpen() crashing on questionable .aux file

Reported by: warmerdam Owned by: warmerdam
Priority: normal Milestone: 1.4.3
Component: GDAL_Raster Version: 1.4.1
Severity: normal Keywords: hfa
Cc: dron, gaopeng

Description

GDALOpen() in 1.4 crashes when given an .aux file with an RRDNamesList() looking like this: 

    RRDNamesList(Eimg_RRDNamesList) @ 6133 + 229 @ 6261
    + algorithm = 
    +     string = `IMAGINE 2X2 Resampling'
    + nameList[0] = 
    +     string = `ntf8_1u_ui_atlanta.rrd(:Band_1:_ss_4_)'
    + nameList[1] = 
    +     string = `ntf8_1u_ui_atlanta.rrd(:Band_1:_ss_8_)'
    + nameList[2] = 
    +     string = `ntf8_1u_ui_atlanta.rrd(:Band_1:_ss_16_)'
    + nameList[3] = 
    +     string = `ntf8_1u_ui_atlanta.rrd(:Band_1:_ss_32_)'
    + nameList[4] = 
    + nameList[5] =

The problem does not occur in trunk.

Change History

Changed 6 years ago by warmerdam

  • cc dron, gaopeng added
  • status changed from new to closed
  • resolution set to fixed

It turns out the previously applied r11303 by Andrey ("Added number of buffer size checks to prevent overruns.") makes the HFA reading code quite a bit safer in the face of funky files.

Applying in 1.4 branch and 1.4-esri branch.

Note that this missed the 1.4.2 release.

Note: See TracTickets for help on using tickets.