Ticket #1622 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

BLOB support in MySQL driver not working

Reported by: Kosta Assigned to: mloskot
Priority: normal Milestone: 1.4.2
Component: OGR_SF Version: unspecified
Severity: normal Keywords: MySQL BLOB
Cc: warmerdam, hobu

Description

The BLOB support in the MySQL driver is completely messed up:

  1. During field type determination MySQL FIELD_TYPE_BLOB is assigned as OFTString (ogrmysqlresultlayer.cpp: 163).
  2. The MySQL types FIELD_TYPE_TINY_BLOB, FIELD_TYPE_MEDIUM_BLOB, and FIELD_TYPE_LONG_BLOB are not handled (ogrmysqlresultlayer.cpp: 163).
  3. In CreateField?() the case of OFTBinary is not handled (ogrmysqltablelayer.cpp: 887).
  4. In CreateFeature?() (ogrmysqltablelayer.cpp: 735) the call to GetFieldAsString?() will truncate binary data to something about 40 bytes (~80 hex digits => see TEMP_BUFFER_SIZE in ogrfeature.cpp: 949).
  5. Binary data must/should be supplied to MySQL via "x'<hex digits>'".

A patch fixing the above issues is attached...

The patch also fixes another issue:

Attachments

mysql_blob.patch (3.1 kB) - added by Kosta on 05/09/07 05:34:09.
bug fixes for BLOB support in MySQL driver
mysql_blob_simple_test.zip (2.5 kB) - added by mloskot on 05/15/07 10:24:25.
This is simple test of read and write BLOB data to MySQL database. This test uses WKB stream read from multipoint.wkb file, as a sample binary data.

Change History

05/09/07 05:34:09 changed by Kosta

  • attachment mysql_blob.patch added.

bug fixes for BLOB support in MySQL driver

05/09/07 09:22:41 changed by warmerdam

  • owner changed from warmerdam to mloskot.
  • cc set to warmerdam, hobu.
  • severity changed from major to normal.
  • milestone set to 1.4.2.

Mateusz,

Please verify, incorporate and test.

I don't know if there is a mysql test script currently. If not, I'd suggest you add a long term todo item to create one rather than do it immediately. I've added Howard to the cc list in case he would like to take this ticket or has some opinions on the change.

05/15/07 10:24:25 changed by mloskot

  • attachment mysql_blob_simple_test.zip added.

This is simple test of read and write BLOB data to MySQL database. This test uses WKB stream read from multipoint.wkb file, as a sample binary data.

05/15/07 10:24:35 changed by mloskot

  • status changed from new to assigned.

05/15/07 10:26:52 changed by mloskot

  • status changed from assigned to closed.
  • resolution set to fixed.

Applied in r11522.

05/15/07 10:39:49 changed by mloskot

Also applied to the stable branch 1.4, so it will be included in new coming 1.4.2 (r11523).