PostGIS fetches 1 at a time

[pramsey@…]

In ogrpglayer.cpp a CURSOR is prepared and features are fetched, but they are only fetched one at a time (#define CURSOR_PAGE 1). This is optimally memory efficient, but very database inefficient. A few hundred or thousand at a time would work better.

[warmerdam]

Reassign to Mateusz

I'd like this fixed in 1.4 branch as well as trunk.

[mloskot]

I reviewed this issue and run tests on big datasets (~500K of features), using index or not, etc.
I compared timing logged by PostgreSQL for various CURSOR_PAGE values:
1, 100, 250, 500 and decided to set the value page to 500 tuples.

Detailed changeset:
http://trac.osgeo.org/gdal/changeset/10871

I resolve it as FIXED.

[warmerdam]

Mateusz, 

It doesn't seem from this report that the fix was also applied to the
1.4.x branch, but it should be.  Please be specific about where changes
are made in the bug reports. 

[mloskot]

Frank,

Yes, I forget to apply it to the 1.4.
I just backported these changes to the branches/1.4, here is the changeset:

http://trac.osgeo.org/gdal/changeset/10874

I'll follow your suggestions.