update interface to latest dwg/dxf lib

[gok@…]

To use dwg/dxf support gdal interface should be updated. Switch/redefine OdChar* to OdString&, OdUInt32 to OdUInt64 in ogr_dwg.h, odfilebuf.h/cpp

[tcollett]

Have attached a patch to update DWG support to use DWG Direct library 2.04.01

[gok]

ogr_dwg.h

[gok]

In order to support latest 2.05.01 DWG/DXF library (DDWG) from ODA. And I hope it will support all future DDWG versions.

Changes done in ogr_dwg.h header (attached):

• switch from OdChar * to OdString &
• change OdInt32 to OdInt64
• make MyServices available (drop ifdef notdef) and put this name in OdStaticRxObject<MyServices> svcs;

DDWG has its own file buffer classes OdFileBuf.h, OdFileBuf.cpp in ddwg25\Extensions\ExServices so my guess there is no reason to keep it in gdal trunk gdal-1.4.4\ogr\ogrsf_frmts\dxfdwg. Just move those files out of gdal scope and add the same from DDWG.

Building with msvc 8.0 extra DDWG lib linked list:

DD_vc8MD_PdfToolkit.lib DD_vc8MD_PdfExport.lib DD_VC8MD_RxRasterServices.lib Gs_WinOpenGL.lib Gs_WinGDI.lib DD_VC8MD_Br.lib DD_VC8MD_BrepRenderer.lib DD_VC8MD_AcisBuilder.lib DD_VC8MD_ModelerGeometry.lib DD_VC8MD_DbCommands.lib DD_VC8MD_Alloc.lib DD_VC8MD_SvgExport.lib DD_VC8MD_Gi.lib DD_VC8MD_Jpeg.lib DD_VC8MD_Db.lib DD_VC8MD_DbRoot.lib DD_VC8MD_Ge.lib DD_VC8MD_Gs.lib DD_VC8MD_Root.lib opengl32.lib DD_VC8MD_ZLib.lib DD_VC8MD_zip.lib DD_VC8MD_SpatialIndex.lib DD_VC8MD_BmpExport.lib DD_VC8MD_RxPlotStyleServices.lib DD_VC8MD_DynBlocks.lib DD_VC8MD_Ave.lib DD_VC8MD_RxRasterProcessor.lib DD_vc8MD_Dwf7Import.lib DD_vc8MD_Dwf7Export.lib WhipTk.lib W3Dtk.lib DwfToolkit.lib DD_VC8MD_ExFieldEvaluator.lib DD_vc8MD_PlotSettingsValidator.lib DwfCore.lib

[warmerdam]

Gok,

If you could test an implementation without the local OdFileBuf.cpp/h that would be very helpful. These were the only reason I had to move the dxfdwg driver out of mainstream GDAL.

[warmerdam]

I have committed the changes in gdal_diff (r13546). Are there distinct changes in the ogr_dwg.zip attachment? Can you guys (gok / tcollett) confirm here that you understand these changes are being contributed under the MIT/X license and that you have the right/permission to provide them?

[tcollett]

No problem with the MIT/X license. The changes were based on the DWG examples (as was the original plugin) so there should be no problems there.

[gok]

driver implementation suggestions

[gok]

If you could test an implementation without the local OdFileBuf.cpp/h that would be very helpful...

With those changes I did build gdal from trunk using nmake /NOLOGO /f makefile.vc default and using vc8 project as well. Attached is modified nmake.opt to support DWG/DXF.

I'm not familiar with GDAL structure so somebody should implement driver, datasource. Some suggestions are in attached ogrdwgdriver/datasource code (dxfdwg.zip)

[Markus Neteler]

Possibly related to ticket #227 ?

[Even Rouault]

Another DXF driver with read & write support has been added into OGR 1.7.0