SDE connection failed message non descriptive

[mchapman]

When trying to connect to sde in OGRSDEDataSource::Open() using an IP address the api returns an empty or non descriptive error making it appear as though a critical error occurred. The solution is to pass a server UNC or friendly name. This wasn't clear to me and I spent a little while trying to figure it out, so I thought by adding a check for an ip address or localhost it would be helpful to new users of the driver.

Is that ok with you Howard/Frank?

[warmerdam]

I'm all for more informative error messages.  Beyond that I have no opinion.
Adding Howard for comment.  

[warmerdam]

Really adding hobu this time.

[hobu]

Martin,

I can connect to IP addresses as long as they are outside my local subnet and not in my windows domain, so maybe it has something to do with windows networking. On linux, I can definitely use 'localhost' as the server name (I run the server and test on a VMware instance ), so in both cases I really think the issue is windows related.

Pushing this one off into 1.6. Close if you wish.