Changes between Version 33 and Version 34 of FDORfc34

Timestamp:

Aug 26, 2009, 7:02:28 PM (15 years ago)

Author:

klain

Comment:

--

FDORfc34

@@ -601 +601 @@
 A high level class diagram of existing reader related interfaces in FDO is as illustrated below. 
  
-Both FdoISqlReader and FdoIDataReader have the function to get the column name or property name according to the index. With this capability, it should be pretty easy to provide default implementation for all indexed access functions. Take FdoIDataReader as an example:
+Both FdoISqlReader and FdoIDataReader have the function to get the column name or property name according to the index. With this capability, it should be pretty easy to provide default implementation for all access by index functions. Take FdoIDataReader as an example:
 
 class FdoIDataReader: public FdoIReader
 {
 public:
-    virtual FdoInt32 GetInt32(FdoInt32 index);
+    virtual FdoInt32 GetInt32(FdoInt32 index)
+    {
+        FdoStringP propName = GetPropertyName(index);
+        return GetInt32(propName);
+    }
 }
-
-An implementation file (IDataReader.cpp) needs to be added:
-
-FdoInt32 FdoIDataReader::GetInt32(FdoInt32 index)
-{
-    FdoStringP propName = GetPropertyName(index);
-    return GetInt32(propName);
-}
-
-Note here, FdoIDataReader is overriding the GetInt32(FdoInt32 index) derived from FdoIReader. So providers can inherit the default implementation automatically without changing any codes. It only needs a recompile. Off course, providers can choose to override the default implementation by theirs if they like. 
 
 In order to make it work in all cases, FdoIFeatureReader also needs to expose a function of FdoString* GetPropertyName(FdoInt32 index) and each provider needs to override it. It has been illustrated in above updated FdoIFeatureReader interface. This work is avoidless that each provider has to know how to map between property name and index for the default implementation. 
@@ -655 +649 @@
 All pure virtual functions for access by index are overrided with the default implementation in a similar way. e.g. 
 {{{
-FdoBoolean FdoIFeatureReaderByIndex ::IsNull(FdoInt32 index)
+FdoBoolean FdoIFeatureReaderByIndex::IsNull(FdoInt32 index)
 {
     FdoStringP propName = GetPropertyName(index);
@@ -669 +663 @@
 }
 }}}
-It is expected that resourcing will be supplied to modify all the existing FDO Open Source providers. Unless there are noticeable performance complaints, all of the open source providers will use the default implementation for this release. 
+It is expected that resourcing will be supplied to modify all the existing FDO Open Source providers. Unless there are noticeable performance complaints, all of the open source providers will use the default implementation for this time. 
 
 == Test Plan ==