Changes between Version 11 and Version 12 of FDORfc22

Timestamp:

Sep 9, 2009, 12:03:59 PM (15 years ago)

Author:

danstoica

Comment:

During implemenation a design error has been detected.

FDORfc22

@@ -99 +99 @@
 
 == CORRECTION ==
-FdoConcatFunction class doesn't extend FdoFunctionDefinition class. Therefore the new method FdoFunctionDefinition::SupportsVariableArgumentsList() is not virtual and the FdoFunctionDefinition constructors need to take an extra parameter.
+FdoConcatFunction class doesn't extend FdoFunctionDefinition class. Therefore the new method FdoFunctionDefinition::SupportsVariableArgumentsList() is not virtual and the FdoFunctionDefinition constructors need to take an extra parameter instead.
 
 Therefore the correct changes are:
@@ -120 +120 @@
 FDO_API bool FdoFunctionDefinition::SupportsVariableArgumentsList();
 
-/// Existing Create methods will take a new 'supportsVariableArgumentsList = false' input parameter.
+/// The existing 3 Create methods will take a new 'supportsVariableArgumentsList = false' input parameter as the last input parameter.
 
-FDO_API static FdoFunctionDefinition *Create (FdoString                       *name,
-                                                  FdoString                       *description,
-                                                  FdoDataType                     returnType,
-                                                  FdoArgumentDefinitionCollection *arguments,
-                                                  FdoFunctionCategoryType         functionCategoryType = FdoFunctionCategoryType_Unspecified,
-                                                  bool                            supportsVariableArgumentsList = false);
+    /// Input a flag indicating whether or not this function supports a variable list of arguments
+    /// \param supportsVariableArgumentsList
 
-// Similar for the other 2 Create methods...
+FDO_API static FdoFunctionDefinition *Create (..., bool supportsVariableArgumentsList = false);
+
 }}}