Changes between Version 11 and Version 12 of FDORfc22


Ignore:
Timestamp:
Sep 9, 2009 12:03:59 PM (10 years ago)
Author:
danstoica
Comment:

During implemenation a design error has been detected.

Legend:

Unmodified
Added
Removed
Modified
  • FDORfc22

    v11 v12  
    9999
    100100== CORRECTION ==
    101 FdoConcatFunction class doesn't extend FdoFunctionDefinition class. Therefore the new method FdoFunctionDefinition::SupportsVariableArgumentsList() is not virtual and the FdoFunctionDefinition constructors need to take an extra parameter.
     101FdoConcatFunction class doesn't extend FdoFunctionDefinition class. Therefore the new method FdoFunctionDefinition::SupportsVariableArgumentsList() is not virtual and the FdoFunctionDefinition constructors need to take an extra parameter instead.
    102102
    103103Therefore the correct changes are:
     
    120120FDO_API bool FdoFunctionDefinition::SupportsVariableArgumentsList();
    121121
    122 /// Existing Create methods will take a new 'supportsVariableArgumentsList = false' input parameter.
     122/// The existing 3 Create methods will take a new 'supportsVariableArgumentsList = false' input parameter as the last input parameter.
    123123
    124 FDO_API static FdoFunctionDefinition *Create (FdoString                       *name,
    125                                                   FdoString                       *description,
    126                                                   FdoDataType                     returnType,
    127                                                   FdoArgumentDefinitionCollection *arguments,
    128                                                   FdoFunctionCategoryType         functionCategoryType = FdoFunctionCategoryType_Unspecified,
    129                                                   bool                            supportsVariableArgumentsList = false);
     124    /// Input a flag indicating whether or not this function supports a variable list of arguments
     125    /// \param supportsVariableArgumentsList
    130126
    131 // Similar for the other 2 Create methods...
     127FDO_API static FdoFunctionDefinition *Create (..., bool supportsVariableArgumentsList = false);
     128
    132129}}}
    133130