Ticket #312 (closed defect: fixed)

Opened 4 months ago

Last modified 4 months ago

PostGIS provider : remove boost_date_time dll dependency

Reported by: bscott Assigned to: mloskot
Priority: minor Milestone: 3.4.0
Component: PostGIS Provider Version: 3.2.0
Severity: 4 Keywords:
Cc: External ID:

Description

This is the only provider that need the boost_date_time dll Or we add this dll in the distribution of FDO 3.3 and higher Or we remove this dependency, quite easy to replace by generic c++ function

ACtually i have already did the implementation patch will follow

Change History

04/19/08 04:27:17 changed by mloskot

Bruno,

I don't mind to remove the dependency, however I'd add that we've agreed to allow use of any library included in the Boost set.

04/19/08 06:33:23 changed by mloskot

Patch submitted for review as #318

(follow-up: ↓ 4 ) 04/19/08 23:57:06 changed by jbirch

Agreed with Mateusz here. I believe that the date time library is already being distributed with FDO 3.3.x and with MapGuide? 2.0.

In this case, it may have been needed to provide a granular-enough random seed for a unique session ID. Using seconds (or something slightly smaller?) turned out not to be granular enough when generating tiles at a rapid rate through multiple active connections. Transaction identifiers (or something like that) ran into naming collisions.

(in reply to: ↑ 3 ) 04/21/08 05:05:04 changed by bscott

Replying to jbirch: When we install Mapguide 2.0 and Map 2009 the only boost dll present is boost_thread-vc80-mt-1_34_1.dll. the boost_date_time-vc80-mt-1_34_1.dll is not part of the install. For a end user this dll is very difficult to find. Adding this dll to the provider binaries is not a clean solution. As Map 2009 is already shiiping, it is not possible to have this dll in the setup. This is why i tough it was a simpler solution to remove this dependency.

04/21/08 13:49:33 changed by mloskot

  • status changed from new to assigned.

Just to remind, I'm completely OK with removing the Boost dependency for this purpose :-)

04/21/08 13:49:56 changed by mloskot

  • status changed from assigned to closed.
  • resolution set to fixed.

Fixed in trunk (r3904) with patch from Bruno Scott. I'm closing it as fixed. Please, reopen if something is still not working well.